1696219 - Serializable attribute on WebIDL fails in C++ errors

Status: NEW

(Core :: DOM: Bindings (WebIDL), defect, P5)

Description

[Dzmitry Malyshau [:kvark]]

[Pref="dom.webgpu.enabled",
 Exposed=Window,
 Serializable]
interface GPURenderPipeline {
};

Ends up with a C++ compile error:

 3:01.86 WebIDLSerializable.cpp:59:16: error: use of undeclared identifier 'SCTAG_DOM_GPURENDERPIPELINE'
 3:01.86     /* mTag */ SCTAG_DOM_GPURENDERPIPELINE,
 3:01.86                ^
 3:01.86 WebIDLSerializable.cpp:81:22: error: cannot use incomplete type 'const mozilla::dom::WebIDLSerializableEntry []' as a range
 3:01.86   for (auto& entry : sEntries) {

We either need to implement this properly, or issue a proper error coming from WebIDL pointing about invalid construct, if this isn't meant to be supported. A C++ error here is confusing.

Comment 1

[Edgar Chen [:edgar]]

WebIDL codegen won't generate the definition of StructuredCloneTags, you need to define it on your own in https://searchfox.org/mozilla-central/source/dom/base/StructuredCloneTags.h.

Comment 2

[Dzmitry Malyshau [:kvark]]

Thank you for the pointers! Can we have a more civilized error message in this case?

Comment 3

[Kelsey Gilbert [:jgilbert]]

Serializable annotations were removed from webgpu for v1.