Split SearchService._getSortedEngines into two for readability
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: standard8, Assigned: janey, Mentored)
Details
(Whiteboard: [lang=js])
Attachments
(1 file, 7 obsolete files)
As mentioned in https://phabricator.services.mozilla.com/D105031#inline-598754, it would be good for readability of code to split SearchService._getSortedEngines into two, e.g. _getSortedEngines and _getSortedVisibleEngines.
|
Reporter | |
Comment 1•3 years ago
|
||
Taking another look at this, this._getSortedEngines(true) calls can simply be replaced by this._sortedEngines. this._getSortedEngines(false) can then be replaced by a getter, e.g. this._sortedVisibleEngines.
The affected function is here: https://searchfox.org/mozilla-central/rev/2c4b830b924f42283632b70f39a60fd36433dd4d/toolkit/components/search/SearchService.jsm#1225-1241
Tests can be run via ./mach xpcshell-test toolkit/components/search
|
Assignee | |
Comment 2•3 years ago
|
||
Hey its Jane here from Outreachy if its possible would love to work on this one pleeeease!
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
|
Assignee | |
Comment 6•3 years ago
|
||
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 7•3 years ago
|
||
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 8•3 years ago
|
||
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 9•3 years ago
|
||
|
|
Assignee | |
Comment 10•3 years ago
|
||
Depends on D128562
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Comment 11•3 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e5cf61ceab6 Split SearchService._getSortedEngines into two for readability. r=Standard8
|
||
Comment 12•3 years ago
|
||
| bugherder | ||
Description
•