1696285 - windows_toolchain.py fails with python 3

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Rob Lemley [:rjl]]

Running windows_toolchain.py as follows:

./mach python ./build/windows_toolchain.py create-zip /c/vs2017

Fails immediately:

Traceback (most recent call last):
  File "./build/windows_toolchain.py", line 262, in <module>
    write_zip(destzip, prefix=prefix)
  File "./build/windows_toolchain.py", line 230, in write_zip
    if isinstance(prefix, unicode):  # noqa Special case for Python 2
NameError: name 'unicode' is not defined

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1696285 - update windows_toolchain.py to run with Python 3. r?#firefox-build-system-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb18352a2512
update windows_toolchain.py to run with Python 3. r=firefox-build-system-reviewers,andi,mhentges

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/eb18352a2512