1696359 - Broken build on arm/arm64 with older kernel (missing __NR_statx, __NR_rseq)

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P2)

Description

[msirringhaus]

I currently get a broken build on arm/arm64 on systems with older kernels:

[ 5479s] 87:35.87 /home/abuild/rpmbuild/BUILD/firefox-86.0/security/sandbox/linux/SandboxFilter.cpp: In member function"virtual mozilla::SandboxPolicyBase::ResultExpr mozilla::SandboxPolicyCommon::EvaluateSyscall(int) const":
[ 5479s] 87:35.87 /home/abuild/rpmbuild/BUILD/firefox-86.0/security/sandbox/linux/SandboxFilter.cpp:594:14: error: "__NR_statx" was not declared in this scope; did you mean "__lxstat"?

and the same for __NR_rseq.

I'm guessing its because of bug 1651701.
Comment 5 says that the in-tree definitions solve this. But only for x86(_64).

Currently, I'm running a test build that adds those definitions to

security/sandbox/chromium/sandbox/linux/system_headers/arm_linux_syscalls.h
security/sandbox/chromium/sandbox/linux/system_headers/arm64_linux_syscalls.h

using the definitions from here and here

Seems to compile fine, but an actual runtime test is still pending. Trying to do it today.

Is there anything else I need to be aware of? Otherwise, I would submit the patch.

Comment 1

[msirringhaus]

Attachment: Bug 1696359 - Broken build on arm/arm64 with older kernel (missing __NR_statx, __NR_rseq)

Comment 2

[msirringhaus]

My manual runtime test seemed to be fine.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:msirringhaus, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429670fd0670
Broken build on arm/arm64 with older kernel (missing __NR_statx, __NR_rseq) r=jld

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/429670fd0670

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something you'd want to see backported to Beta/ESR? Seems pretty low-risk if it helps downstream.

Comment 7

[msirringhaus]

I currently don't see the build failure on 78 ESR, so at least for me backporting is not needed.
Thanks for the offer, though!

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:msirringhaus, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.