Closed Bug 1696359 Opened 9 months ago Closed 6 months ago

Broken build on arm/arm64 with older kernel (missing __NR_statx, __NR_rseq)

Categories

(Core :: Security: Process Sandboxing, defect, P2)

Firefox 86
ARM64
Linux
defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: msirringhaus, Assigned: msirringhaus)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I currently get a broken build on arm/arm64 on systems with older kernels:

[ 5479s] 87:35.87 /home/abuild/rpmbuild/BUILD/firefox-86.0/security/sandbox/linux/SandboxFilter.cpp: In member function"virtual mozilla::SandboxPolicyBase::ResultExpr mozilla::SandboxPolicyCommon::EvaluateSyscall(int) const":
[ 5479s] 87:35.87 /home/abuild/rpmbuild/BUILD/firefox-86.0/security/sandbox/linux/SandboxFilter.cpp:594:14: error: "__NR_statx" was not declared in this scope; did you mean "__lxstat"?

and the same for __NR_rseq.

I'm guessing its because of bug 1651701.
Comment 5 says that the in-tree definitions solve this. But only for x86(_64).

Currently, I'm running a test build that adds those definitions to

security/sandbox/chromium/sandbox/linux/system_headers/arm_linux_syscalls.h
security/sandbox/chromium/sandbox/linux/system_headers/arm64_linux_syscalls.h

using the definitions from here and here

Seems to compile fine, but an actual runtime test is still pending. Trying to do it today.

Is there anything else I need to be aware of? Otherwise, I would submit the patch.

Regressed by: 1651701
Assignee: nobody → msirringhaus
Severity: -- → S4
Priority: -- → P2

My manual runtime test seemed to be fine.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:msirringhaus, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(msirringhaus)
Flags: needinfo?(jld)
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/429670fd0670
Broken build on arm/arm64 with older kernel (missing __NR_statx, __NR_rseq) r=jld
Status: UNCONFIRMED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Is this something you'd want to see backported to Beta/ESR? Seems pretty low-risk if it helps downstream.

Flags: needinfo?(msirringhaus)
Flags: needinfo?(jld)
Flags: needinfo?(msirringhaus)

I currently don't see the build failure on 78 ESR, so at least for me backporting is not needed.
Thanks for the offer, though!

Flags: needinfo?(msirringhaus)

The patch landed in nightly and beta is affected.
:msirringhaus, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(msirringhaus)
You need to log in before you can comment on or make changes to this bug.