Open Bug 1696367 Opened 4 years ago Updated 3 years ago

Apply the inlining guideline in dom/bindings

Categories

(Core :: DOM: Bindings (WebIDL), task, P5)

Product:
Core
Component:
DOM: Bindings (WebIDL)
Type:
task

Tracking

()

People

(Reporter: sg, Unassigned)

References

Details

Attachments

(2 files)

Bug 1696367 - Avoid unnecessary includes in CallbackObject.h/ScriptSettings.h by de-inlining.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1696367 - Avoid including CallbackObject.h in ToJSValue.h by de-inlining.
47 bytes, text/x-phabricator-request
Details | Review

The attached patches were carried over from Bug 1673931 after peterv raised concerns that these might have negative performance impacts in non-LTO builds. Depending on the outcome, these patches might land or be abandoned. OTOH, they may serve as examples in discussing that guideline.

Component: Source Code Analysis → DOM: Bindings (WebIDL)
Product: Firefox Build System → Core
Severity: -- → N/A
Priority: -- → P5
Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Assignee: sgiesecke → nobody
Status: ASSIGNED → NEW
Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Assignee: simon.giesecke → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: