Add a test for custom accessors for FOG labeled metrics in JS
Categories
(Toolkit :: Telemetry, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: Dexter, Assigned: perry.mcmanis, Mentored)
Details
(Whiteboard: [telemetry:fog:m?][good next bug][lang=js])
Attachments
(1 file, 1 obsolete file)
Our tests only test the glean.metric.this_is_a_label.set() syntax, but do not mention nor test glean.metric["this_is_a_label"].set().
While the former syntax is handy (and makes compiler happy) if the label only has underscores in it, Glean labels also allow using . and -, forcing users to use the latter syntax.
|
||
Comment 1•3 years ago
|
||
The linter auto-corrects Glean.category.metric["this_is_a_label"].operation(args) to Glean.category.metric.this_is_a_label.operation(args), so we'll have difficulty testing that form for labels that are valid JS identifiers.
But since . is a permitted character for labels, let's use that to avoid the linter and make the test even more complete.
|
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
||
Comment 4•2 years ago
|
||
Comment on attachment 9285571 [details]
drr_2022_07_14.txt
If no population is being measured, no data is being collected that needs to be passed through Data Collection Review. This test-only metric is free to be collected.
Pushed by pmcmanis@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9994d22af44f Add tests for labled metric accessors including custom accessors for JS style accessors r=chutten
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•