1696456 - Rename budget to minimumUsefulBudget in IdleTaskRunner

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P5)

Description

[Steve Fink [:sfink] [:s:]]

"Budget" implied to me that it would be used as the budget for the GC slice that the runner invoked, but it's only used to decide whether there's enough idle time available to run the callback. The latter suggests using a small value, whatever duration seems worth triggering a slice for. The former suggests using a larger value, a slice duration that balances overhead with work done.

But mainly: I messed up and renamed the parameter from aBudget to aNonIdleBudget because I misinterpreted what it was being used for. I could just rename it back, but I think aMinimumUsefulBudget is a slightly better name.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1696456 - Rename budget to minimumUsefulBudget in IdleTaskRunner

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d562bfe87b82
Rename budget to minimumUsefulBudget in IdleTaskRunner r=smaug

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d562bfe87b82