1696471 - Emit target-destroyed-form for all cases where we used to emit tabDetached

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

In order to be able to complete bug 1631451 and remove tabDetached in favor of target-destroyed-form, we ought to emit target-destroyed-form for all cases where we currently emit tabDetached.

When removing tabDetached I identified two cases:

• top level tab target, when doing a process switch is missing such event
• content process targets are used to have tabDetached on teardown (this isn't something we do for all targets)

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1696471 - [devtools] Notify about top level target destruction via watcher's target-destroyed-form.

This is a workaround, until the top level target uses the JSWindowActor codepath.
This will help get rid of tabDetached in favor of target-destroyed-form.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1696471 - [devtools] Properly close transports for content process targets.

There was a typo in item.watcher != watcher...

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1696471 - [devtools] Notify about content process target destruction via watcher's target-destroyed-form.

We are currently receiving tabDetached for content process targets
when we destroy them via:
Services.ppmm.broadcastAsyncMessage("debug:destroy-process-script")
done from process-helper and we stop watching for process targets.
Tests now depends on this behavior.

So I'm trying to replicate this behavior in order to later get rid of tabDetached
in favor of target-destroyed-form.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9e899f1a7551c996e76e2e78bd6cf1847d7059dc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4476f926c4f
[devtools] Notify about top level target destruction via watcher's target-destroyed-form. r=nchevobbe,jdescottes
https://hg.mozilla.org/integration/autoland/rev/63799ea4103b
[devtools] Properly close transports for content process targets. r=nchevobbe,jdescottes
https://hg.mozilla.org/integration/autoland/rev/1acce6920635
[devtools] Notify about content process target destruction via watcher's target-destroyed-form. r=nchevobbe,jdescottes

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c4476f926c4f
https://hg.mozilla.org/mozilla-central/rev/63799ea4103b
https://hg.mozilla.org/mozilla-central/rev/1acce6920635