Closed
Bug 1696491
Opened 5 years ago
Closed 5 years ago
clang-tidy job with errors is still green
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox88 fixed)
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: kvark, Assigned: andi)
Details
Attachments
(1 file)
I'd expect it to reflect the failure in "red", so that I know this can't land based on looking at the try push.
|
||
Comment 1•5 years ago
|
||
I think the reviewbot expects green jobs to feed phabricator.
Flags: needinfo?(bpostelnicu)
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → bpostelnicu
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1)
I think the reviewbot expects green jobs to feed phabricator.
This was the expected behavior in the past, but nowadays we no longer need to have that.
Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b50ad92d0d0
when clang errors are present, mark static analysis jobs as failed. r=firefox-build-system-reviewers,mhentges
|
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•