Closed Bug 1696491 Opened 3 years ago Closed 3 years ago

clang-tidy job with errors is still green

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

defect

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: kvark, Assigned: andi)

Details

Attachments

(1 file)

See https://treeherder.mozilla.org/jobs?repo=try&revision=a31ac5f30e277552f40efbac8986d7f14007abe7&selectedTaskRun=aW-jkRfqQS6QxevDmvO_7g.0

I'd expect it to reflect the failure in "red", so that I know this can't land based on looking at the try push.

I think the reviewbot expects green jobs to feed phabricator.

Flags: needinfo?(bpostelnicu)
Assignee: nobody → bpostelnicu
Status: NEW → ASSIGNED

(In reply to Mike Hommey [:glandium] from comment #1)

I think the reviewbot expects green jobs to feed phabricator.

This was the expected behavior in the past, but nowadays we no longer need to have that.

Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b50ad92d0d0
when clang errors are present, mark static analysis jobs as failed. r=firefox-build-system-reviewers,mhentges
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: