Closed
Bug 1696524
Opened 3 years ago
Closed 3 years ago
[Proton] Tab shadow doesn't match the spec
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: jaws, Assigned: emmamalysz)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-tabs-bar])
Attachments
(1 file)
The shadow for a selected tab should be:
box-shadow: 0px 1px 2px rgba(58, 57, 68, 0.1);
The shadow for a selected hovered tab should be:
box-shadow: 0px 2px 6px rgba(58, 57, 68, 0.2);
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-409
Reporter | ||
Updated•3 years ago
|
Priority: P3 → P1
Updated•3 years ago
|
Assignee: nobody → ntim.bugs
Updated•3 years ago
|
Assignee: ntim.bugs → nobody
Reporter | ||
Updated•3 years ago
|
Points: --- → 1
Reporter | ||
Updated•3 years ago
|
Points: 1 → 3
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8360319968cc update selected tab box shadow r=desktop-theme-reviewers,ntim
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Comment 4•3 years ago
|
||
Hello I was trying to verify this issue is fixed and I could not see the dimensions on the shadow of the tab.
Jared could you please recommend a tool I can verify this issue with?
Thank you!
Flags: needinfo?(jaws)
Reporter | ||
Comment 5•3 years ago
|
||
The shadow is being changed again, so I think we should skip testing on this bug. In the future you can use the Browser Toolbox to inspect the tab and see what is set for the shadow.
Flags: needinfo?(jaws)
You need to log in
before you can comment on or make changes to this bug.
Description
•