1696541 - Run talos tasks against Python 3 in CI

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

The harness supports Python 3. We should:

1. Add python-3: true key to all talos tasks
2. Fix errors that pop up on try as a result
3. Add testing/talos to the py2 linter's exclude list (so we can start using Python 3 syntax)

Comment 1

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1696541 - Run talos tasks against Python 3 in CI.r?ahal

Comment 2

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1696541 - Fix talos/talos/ttest.py to support py3.r?ahal

Comment 3

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1696541 - Make testing/talos/talos/xtalos py3 compat.r?jmaher

Depends on D109962

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb581d45f05
Run talos tasks against Python 3 in CI.r=ahal,perftest-reviewers
https://hg.mozilla.org/integration/autoland/rev/fd7d516cc984
Fix talos/talos/ttest.py to support py3.r=perftest-reviewers,jmaher,Bebe,sparky

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/aeb581d45f05
https://hg.mozilla.org/mozilla-central/rev/fd7d516cc984

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #29647 (as of Fri, 09 Apr 2021 14:39:43 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
100%	tp5o	XRes	linux1804-64-shippable	e10s stylo	6,488,958.11 -> 0.00
100%	tp5o	XRes	linux1804-64-shippable-qr	e10s stylo webrender	198,822.81 -> 0.00
100%	tp5o	XRes	linux1804-64-shippable-qr	e10s stylo webrender-sw	6,488,813.16 -> 0.00
100%	tp5o_webext	XRes	linux1804-64-shippable	e10s stylo	6,490,468.95 -> 0.00
100%	tp5o_webext	XRes	linux1804-64-shippable-qr	e10s stylo webrender	198,891.66 -> 0.00
100%	tp5o_webext	XRes	linux1804-64-shippable-qr	e10s stylo webrender-sw	6,488,999.74 -> 0.00
5%	tp5o_webext		macosx1015-64-shippable-qr	e10s stylo webrender-sw	242.34 -> 230.54
5%	tp5o_webext		macosx1015-64-shippable-qr	e10s stylo webrender	241.26 -> 229.80
5%	tp5o_webext		windows10-64-shippable	e10s stylo	354.70 -> 337.97
5%	tp5o		macosx1015-64-shippable-qr	e10s stylo webrender-sw	176.63 -> 168.30
4%	tp5o		windows10-64-shippable-qr	e10s stylo webrender	246.30 -> 236.22
4%	tp5o		windows10-64-shippable	e10s stylo	272.50 -> 262.42
4%	tp5o		macosx1015-64-shippable-qr	e10s stylo webrender	175.64 -> 169.37

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29647

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:alexandrui :bebe XRes dropped to zero, which doesn't look like an improvement to me. Can you investigate?

Comment 8

[Florin Strugariu [:Bebe]]

Dave is right we are not getting XRes metric after this patch.
:championshuttler ] Can you take a look? I have a feeling that it's from https://hg.mozilla.org/integration/autoland/rev/fd7d516cc984c134a760f37a33962ccc123677aa#l1.12

Also we should add a check in there to make sure we don't miss this kind of errors

:alexandrui can you do that please?

Comment 9

[Shivam Singhal [ :championshuttler ]]

I am away, Joel can you please take care of it, thanks

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1696541 - collect xres again after python3 conversion. r=ahal

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

patch to fix this:)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/189b6ae70b81
collect xres again after python3 conversion. r=ahal,perftest-reviewers,sparky

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/189b6ae70b81

Comment 14

[Mitchell Hentges [:mhentges] 🦀]

Should be fixed by D116044.

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

technically we still have talos-xperf to run in python3:
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/talos.yml#665

Comment 16

[Mitchell Hentges [:mhentges] 🦀]

Whoops, I had a suspicion that changing the status of another team's bug would come back to bite me 😁
Re-opened, sorry about that!

Comment 17

[Julien Cristau [:jcristau]]

Bug 1733694 moved talos-xperf to python3.