1696546 - [Proton] A dark line is shown at the top of the selected tab when the menubar is visible

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

A dark line is shown at the top of the selected tab when the menubar is visible. This is also happening on macOS when a tab is dragged.

It looks like this is caused by https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/themes/shared/tabs.inc.css#714-720, which we can disable if Proton is enabled.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1696546 - Don't show border-top-style over active tab in Proton.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/147d0fb218c3
Don't show border-top-style over active tab in Proton. r=jaws

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for mda crashes on libc.so

Backout link: https://hg.mozilla.org/integration/autoland/rev/056c2a428e2ded0b5d372aac48887dcc259cfbed
Log link: https://treeherder.mozilla.org/logviewer?job_id=332629404&repo=autoland&lineNumber=2494

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cd64beb8bf3
Don't show border-top-style over active tab in Proton. r=jaws

Comment 5

[Alexandru Michis [:malexandru]]

Relanded changeset 147d0fb218c3 since after more retriggers the mda failures appear to be machine related.
(reland link): https://hg.mozilla.org/integration/autoland/rev/2cd64beb8bf3cc5d27b85e50c48b9012cdb6e56e

Sorry for the inconvenience!

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2cd64beb8bf3

Comment 7

[Mike Conley (:mconley) (:⚙️)]

This seems to have (inadvertently?) affected the selected tab contrast when Proton is enabled, because this rule is now being bypassed: https://searchfox.org/mozilla-central/rev/491c8096b5dfdb328b2135895062e16e1e36d708/browser/themes/shared/tabs.inc.css#721-727

Comment 8

[Dão Gottwald [:dao]]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #7)

This seems to have (inadvertently?) affected the selected tab contrast when Proton is enabled, because this rule is now being bypassed: https://searchfox.org/mozilla-central/rev/491c8096b5dfdb328b2135895062e16e1e36d708/browser/themes/shared/tabs.inc.css#721-727

This was noted in https://phabricator.services.mozilla.com/D107540#3502524

Comment 9

[Mike Conley (:mconley) (:⚙️)]

ni?ing gandalf for comment 7 / comment 8.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #7)

This seems to have (inadvertently?) affected the selected tab contrast when Proton is enabled, because this rule is now being bypassed: https://searchfox.org/mozilla-central/rev/491c8096b5dfdb328b2135895062e16e1e36d708/browser/themes/shared/tabs.inc.css#721-727

I was applying reviewers feedback from :ntim. Redirecting NI to them.

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98cd5cd5535e
Backed out changeset 2cd64beb8bf3 on dao's request - for not addressing significant flaw CLOSED TREE

Comment 12

[Tim Nguyen :ntim]

I was just referring to the border-top-color property. Anyway, this has been backed out.

Comment 13

[Tim Nguyen :ntim]

ni? back to Zibi about the backout.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ah, I misunderstood you. I'm sorry!

I'll wait for the backout to complete and put a fine-tuned PR for your review.

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/658f0e3e5bcc
Backed out changeset 2cd64beb8bf3 on dao's request - for not addressing significant flaw CLOSED TREE

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Backed out changeset 2cd64beb8bf3 (bug 1696546) on dao's request - for not addressing significant flaw CLOSED TREE

Comment 17

[Tim Nguyen :ntim]

ni? to Dão/Jared now to land this now that Itiel has updated the patch.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eac7995c81c
Don't show border-top-style over active tab in Proton. r=jaws,dao

Comment 19

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8eac7995c81c

Comment 20

[Hani Yacoub, Desktop QA]

Verified as fixed on Nightly 89.0a1 on Windows 10 x64, Windows 7 x64, Ubuntu 20.04 and on macOS 10.15.