1696550 - Disable Firefox Monitor promotional doorhanger when Proton is enabled

Status: RESOLVED FIXED

(Firefox :: Firefox Monitor, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

As it says on the tin. Product and UX have slated this for removal.

We shouldn't show this panel if browser.proton.doorhangers.enabled is true.

This PopupNotification appears to be powered by this code: https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/components/fxmonitor/FirefoxMonitor.jsm#410

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey nhnt11,

I know you're doing Necko-y things lately, but I also think you're kinda the expert on this code right now. Do you think you'd have a short cycle to land a patch to disable this panel if browser.proton.doorhangers.enabled is true?

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1696550 - Suppress Firefox Monitor breach alert doorhangers when proton panels are enabled. r=mconley!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bf8dad2cc7c
Suppress Firefox Monitor breach alert doorhangers when proton panels are enabled. r=mconley

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 2bf8dad2cc7c (bug 1696550) for bc failures at browser_preferences_usage.js.
https://hg.mozilla.org/integration/autoland/rev/466c2d15a0bbc6eb71a91c22096521dd0fdc4413

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=2bf8dad2cc7cbfacb5980a8b8725f35d0cf0fc1e&selectedTaskRun=AMWYjCUxQnG2lLI2EqK9yw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=332719876&repo=autoland&lineNumber=2768

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac9de3689944
Suppress Firefox Monitor breach alert doorhangers when proton panels are enabled. r=mconley

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ac9de3689944

Comment 7

[Luke Crouch [:groovecoder]]

(Sorry I was out all last week and just saw this bugmail.)

Any chance to re-consider this? I would argue that this isn't just "promotional". If someone has an account on a site that's been breached, that's a pretty significant security risk for them. (How) Are we distinguishing between "promotional" doorhangers and functional doorhangers?

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Redirecting to Tyler Duzan from Product, who's responsible for panel decisions for Proton.

Comment 9

[Tyler Duzan]

(In reply to Luke Crouch [:groovecoder] from comment #7)

(Sorry I was out all last week and just saw this bugmail.)

Any chance to re-consider this? I would argue that this isn't just "promotional". If someone has an account on a site that's been breached, that's a pretty significant security risk for them. (How) Are we distinguishing between "promotional" doorhangers and functional doorhangers?

This mechanism is not the breach alert mechanism for users who are signed up for Firefox Monitor, but rather a contextual feature recommendation panel which directs users to Firefox Monitor when they visit a URL with a prior breach. It was discussed with stakeholders and the decision was to remove this as we did for other CFRs, because part of our visual language for MR1 is to provide users with a clean, modern, distraction-free experience while browsing.

We had a lot of promotional panels in the product and while we understand that there needs to be methods to help users with feature discovery, it was pretty noisy. There will likely be another pathway for these sorts of "cross-sell" opportunities in the future, but the panels treatment which is designed around situations where we prompt the user to grant permissions, is not the right way to structure this. It's not in scope to rebuild all of these with MR1, but in keeping with our Firefox Product Design Guidelines, we are removing them.

For users that have enrolled in Firefox Monitor, they still receive breach alerts via the primary mechanism of communication (email).

I'm happy to discuss this further to go into detail about the decision-making process, what our design guidelines are, and what not in a meeting, but as it is, the decision to remove this stands.