1696584 - Minor clean up in layout

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

+++ This bug was initially created as a clone of Bug #1664738 +++

A placeholder bug for random clean up patches in layout while reading code. None of the patches in this bug should change the behavior.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1696584 - Change 'typedef' to 'using' in Coord.h.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1696584 - Removed unused nsLineBox::SetBounds().

Depends on D107312

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1696584 - Make nsBlockFrame::ComputeOverflowAreas return OverflowAreas rather than though outparam.

Depends on D107313

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1696584 - Remove UnionRectEdges() and replace the callers with the equivalent UnionEdges().

UnionRectEdges() and UnionEdges() are equivalent, and the later has a
modern interface with a shorter name. Let's remove the former.

Depends on D107314

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34b5b961708d
Change 'typedef' to 'using' in Coord.h. r=emilio
https://hg.mozilla.org/integration/autoland/rev/703dd254d8b4
Removed unused nsLineBox::SetBounds(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/a6cff5fa00ae
Make nsBlockFrame::ComputeOverflowAreas return OverflowAreas rather than though outparam. r=emilio
https://hg.mozilla.org/integration/autoland/rev/14fac67d1cce
Remove UnionRectEdges() and replace the callers with the equivalent UnionEdges(). r=emilio

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/34b5b961708d
https://hg.mozilla.org/mozilla-central/rev/703dd254d8b4
https://hg.mozilla.org/mozilla-central/rev/a6cff5fa00ae
https://hg.mozilla.org/mozilla-central/rev/14fac67d1cce