Closed Bug 1696585 Opened 3 years ago Closed 3 years ago

switch eliot to use honcho

Categories

(Eliot :: General, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

Attachments

(4 files)

Eliot has a web app that needs multiple workers to run. It also has a cache cleanup process that cleans up the cache directory. When running in the Docker container, we need a process manager to manage the workers and the cache process, multiplex the output to stdout for the Docker container.

I was using circus, but it's a little weird.

Lonnen mentioned I should look at Honcho. I think I did originally, but decided against it because it hadn't had a release in a while and didn't look maintained. I think that assumption was wrong based on this:

https://github.com/nickstenning/honcho/issues/212

Socorro used to use Honcho until I removed it a few years back.

We should look at switching back to Honcho.

Assignee: nobody → willkg

Honcho looks great except that there's a warning for Python 3.8+. Honcho prints this when starting Eliot processes:

eliot_1         | /usr/local/lib/python3.9/subprocess.py:941: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
eliot_1         |   self.stdout = io.open(c2pread, 'rb', bufsize)
eliot_1         | /usr/local/lib/python3.9/subprocess.py:941: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
eliot_1         |   self.stdout = io.open(c2pread, 'rb', bufsize)

It's covered in this issue:

https://github.com/nickstenning/honcho/issues/221

That's fixed in the Honcho master branch, but hasn't been released, yet.

Status: NEW → ASSIGNED

This deployed to stage a few days ago. I see logs for it, so it looks like it's working fine. If not, we'll fix issues in future bugs. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

willkg merged PR #2381: "bug 1696585: remove circus_eliot.ini file" in c726439.

This removes the circus_eliot.ini file I should have removed.

Moving to Eliot product.

Component: Symbolication → General
Product: Tecken → Eliot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: