1696620 - Add additional crash annotations to the crash reports generated by WER

Status: RESOLVED MOVED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

The WER exception module is only currently writing out a minimum set of crash annotations, these should be augmented with the following which it should be possible to extract from without Gecko:

• CrashTime: this is just a call to time().
• StartupTime: this needs to be computed from GetProcessTimes()
• Memory measurements: these include AvailablePageFile, AvailablePhysicalMemory, TotalPageFile, TotalPhysicalMemory and SystemMemoryUsePercentage. See the code in AnnotateMemoryStatus(). There is no point in recording AvailableVirtualMemory and TotalVirtualMemory because we're taking the measurements outside of the crashed process.
• Info about the graphics driver: AdapterDeviceID, AdapterDriverVersion, AdapterSubsysID and AdapterVendorID. These might be harder to extract (I need to study the widget code) but would be very nice to add given that we expect crashes to be coming from graphics drivers too.
• CPUMicrocodeVersion and MemoryErrorCorrection: nice to have but not necessary

Comment 1

[Gabriele Svelto [:gsvelto]]

I have already added the CrashTime annotation but UptimeTS is notably missing. It should be able to implement it by obtaining the process startup time via GetProcessTimes() like we do in the TimeStamp class.

Comment 2

[Gabriele Svelto [:gsvelto]]

I discovered that Socorro doesn't use UptimeTS to display Firefox' uptime but rather CrashTime - StartupTime so I'll add StartupTime instead.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

The processor rule that figures out the uptime value is really janky and I have no confidence that it's correct or is the best "uptime value" we could have. I'm happy to change it.

Comment 4

[Gabriele Svelto [:gsvelto]]

The UptimeTS value that we put in crash reports is garbage. It means different things on different platforms and sometimes different things even on the same platform. CrashTime - StartupTime is a better choice ATM because at least it's consistent.

Comment 5

[Gabriele Svelto [:gsvelto]]

Actually I might just add both StartupTime and UptimeTS and make the latter be CrashTime - StartupTime. It doesn't hurt and then I'm sure that if there are users of both they get whatever field they're looking at.

Comment 6

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1696620 - Flag crash reports intercepted by WER with a special annotation r=KrisWright

Depends on D115380

Comment 7

[Gabriele Svelto [:gsvelto]]

Ugh, wrong bug, this was meant for bug 1703761.

Comment 8

[Gabriele Svelto [:gsvelto]]

We'll deal with this in bug 1874889.