1696638 - Password Quality meter bar overlaps with the text in the Primary Password setup modal

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of the issue

Affected Versions:
Nightly 88.0a1 (2021-03-05)

Tested on:
Windows 7/10
MacOS 10.15
Ubuntu 20.04

Steps to reproduce:

1. Got to about:prefereces#privacy
2. Choose to use a Primary Password and enter the OS auth password
3. Reach the Primary Password setup modal

Expected Results:
The password quality meter should be aligned correctly without being overlapped or overlapping other modal elements.

Actual Results:
Password Quality meter bar overlaps with text in Primary Password setup modal

Regression-Range:
Regression caused by Bug 1590884.
2021-03-05T14:12:01.458000: DEBUG : Found commit message:
Bug 1590884 - Move XUL accesskey handling to DOM and remove nsXULLabelFrame. r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D106233

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hey Tim, please take a look at this when you have the time, thanks!

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1696638 - Remove obsolete .header preferences.css & common.css styling.

This was originally added in bug 1120967 to space the help button that used to appear in the header. The help button has since been removed.

It's bogus in this case, because it accidentally overrides the display value of some description (which used to force their own display value).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff5c36b7a05f
Remove obsolete .header preferences.css & common.css styling. r=preferences-reviewers,Gijs

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ff5c36b7a05f

Comment 5

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on Windows 7/10, MacOS 10.15 and Ubuntu 20.04 on the latest Firefox Nightly 88.0a1 (2021-03-19) (64-bit).