Closed
Bug 1696643
Opened 5 years ago
Closed 5 years ago
Remove some unused functions in js/src/frontend
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(6 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Part 1 removed the only other caller to this method.
Depends on D107328
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D107329
|
|
Assignee | |
Comment 4•5 years ago
|
||
Removes parse handler methods which are never called and were only defined in
one but not the other parse handler.
Depends on D107330
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D107331
|
|
Assignee | |
Comment 6•5 years ago
|
||
This function is only used for the shell, so we might as well move it there.
Depends on D107332
|
||
Updated•5 years ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/90c41eaa1efd
Part 1: Remove SourceKind. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/43016fd0083b
Part 2: Remove ListNode::appendWithoutOrderAssumption. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0df22b20eea2
Part 3: Remove unused JSContext argument. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/82d4f6d8258d
Part 4: Remove unused parse handler methods. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3e805d75aa07
Part 5: Remove unused TokenStream functions. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/822423fd45f6
Part 6: Move js_fgets next to its sole caller. r=mgaudet
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/90c41eaa1efd
https://hg.mozilla.org/mozilla-central/rev/43016fd0083b
https://hg.mozilla.org/mozilla-central/rev/0df22b20eea2
https://hg.mozilla.org/mozilla-central/rev/82d4f6d8258d
https://hg.mozilla.org/mozilla-central/rev/3e805d75aa07
https://hg.mozilla.org/mozilla-central/rev/822423fd45f6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•