1696677 - Autocomplete for url() values don't work for the cursor property

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Micah [:mtigley] (she/her)]

STR

1. Open the DevTools Inspector
2. Go to the Rules view
3. In any rule, try adding a cursor property with a url() value

Expected
While typing in "url", I expect the autocomplete list to show an option for "url"

Actual
No autocomplete option is given for "url"

I think this has to do with the support for a "url" value being removed for the cursor property in https://phabricator.services.mozilla.com/D106745 after using the ./mach devtools-css-db to update the DevTools CSS database.

Comment 1

[Micah [:mtigley] (she/her)]

Looked into this a bit more and it looks like modifying devtools/shared/css/generated/properties-db.js isn't actually what we want (and probably what we shouldn't be doing anyway since it's generated).

I think the next step here is look into this, which is called from GetCSSValuesForProperty. The caller from C++ is through InspectorUtils.GetCSSValuesForProperty.

I wonder if this is because SpecifiedValueInfo is manually implemented for CursorImage now, so it's tripping up what GetCSSValuesForProperty is getting for enabled values for the cursor property . Emilio, perhaps you might know why this is?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yes, this was caused by manually implementing SpecifiedValueInfo for CursorImage. We probably want to just implement collect_completion_keywords and return url and image-set for now.

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1696677 - Have collect_completion_keywords return `url` and `image-set` for CursorImage. r=emilio!

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1696677 - Add tests for ensuring that "url" and "image-set" are autocomplete values for content property. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f82baebe8645
Have collect_completion_keywords return `url`  and `image-set`  for CursorImage. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d479bcc42014
Add tests for ensuring that "url" and "image-set" are autocomplete values for content property. r=emilio

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f82baebe8645
https://hg.mozilla.org/mozilla-central/rev/d479bcc42014

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1695402