Closed Bug 1696807 Opened 4 years ago Closed 3 years ago

https://codepen.io/thebabydino/pen/GRjdEmb has parts of the star missing while rotating

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: mayankleoboy1, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

go to https://codepen.io/thebabydino/pen/GRjdEmb

AR: While the star rotates, parts of it become transparent/disappear
ER: not so

Attached file about:support
Has Regression Range: --- → yes

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Type: task → defect
Severity: -- → S3

This was fixed.

Bug 1749380 - Part 2 - Performance and quality fixes for part 1. r=gfx-reviewers,nical

  • Add support for local scale factors to a surface, allowing it to
    be rasterized in root coordinate space. This allows snapping to
    work across surfaces where the surface transform is a fractional
    offset.

  • Calculate scaling factors per rasterized surface and propagate
    them. Ensures correct scale factor calculations when dealing with
    nested preserve-3d contexts with 90-degree axis rotations.

  • Support determining exact surface device rect for 2d surfaces
    with fractional surface transforms.

  • Fix line decoration cache key size calculations based on world
    scaling factor.

  • Remove get_clipped_device_rect usage for calculating clip-mask
    surface allocations, use surface.get_surface_rect instead. The
    prior method doesn't correctly account for expanded local regions
    from the current dirty rect, resulting in invalidation issues in
    some animated edge cases. Also unifies the way clip-mask surface
    allocations work with the way general render target surface
    allocations work.

Differential Revision: https://phabricator.services.mozilla.com/D138982

2022-08-18T15:42:33.721000: DEBUG : Did not find a branch, checking all integration branches
2022-08-18T15:42:33.730000: INFO : The bisection is done.
2022-08-18T15:42:33.732000: INFO : Stopped

Status: NEW → RESOLVED
Closed: 3 years ago
Depends on: 1749380
Resolution: --- → FIXED

(In reply to Mayank Bansal from comment #4)

Can you re-open please? I can still reproduce it in the latest Firefox Nightly with Software WebRender in a Debian 11 VirtualBox VM with no hardware acceleration.

Flags: needinfo?(mayankleoboy1)

This bug was specific to Hardware Webrender.

I would suggest to file a new bug, and mark it blocking bug 1621381 (which is specific to track rendering issues with Software Webrender).
FYI, I have filed a number of bugs specific to software webrender, and your specific bug just might be a duplicate. ( bug 1710129, bug 1710130, bug 1710131, bug 1710133 ).

Flags: needinfo?(mayankleoboy1)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: