Closed Bug 1696809 Opened 3 years ago Closed 3 years ago

Remove unused code from SearchDialog.js

Categories

(SeaMonkey :: MailNews: Message Display, task)

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.87
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file)

Bug 460953 removed the need for GetFolderDataSource function in SearchDialog.js
The IsThreadAndMessagePaneSplitterCollapsed function never seems to have been used since the code was imported into mercurial

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9207316 - Flags: review?(frgrahl)
Attachment #9207316 - Flags: approval-comm-release?
Attachment #9207316 - Flags: approval-comm-esr60?

Comment on attachment 9207316 [details] [diff] [review]
1696809-searchdialog-tidy-2538.patch

LGTM

Attachment #9207316 - Flags: review?(frgrahl)
Attachment #9207316 - Flags: review+
Attachment #9207316 - Flags: approval-comm-release?
Attachment #9207316 - Flags: approval-comm-release+
Attachment #9207316 - Flags: approval-comm-esr60?
Attachment #9207316 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/bd3df86a4eeb
Remove unused code from SearchDialog.js. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.8
Target Milestone: --- → seamonkey 2.87
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: