1696874 - button focus ring for modal tab dialog should not overlap with letters above button

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot: button focus ring overlapping letters

Firefox 88.0a1 20210307213430 on Windows 8.1

Might be from bug 1693277.

The focus ring for the focused button in tab modal prompts can overlap with the letters from the dialog above it (see screenshot) which can make it more difficult to read it. Could the padding for the button get increased?

Comment 1

[:Gijs (he/him)]

Can you provide steps to reproduce? What OS is this, how do you get this dialog, have you got proton enabled or not? Then we can check if this is a regression or not...

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #0)

Firefox 88.0a1 20210307213430 on Windows 8.1

Without proton. STR: Have a bookmark folder with many bookmarks and click on it with the mousewhell / middle mouse button

Comment 3

[:Gijs (he/him)]

The patch in bug 1693277 set the button margins to 0 4px which is fine in proton when each row gets 20px bottom margin anyway, but we don't do that in non-proton, which is how this situation arises.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1696874 - fix button margins in dialogs in non-proton, r?mtigley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2623dc64891d
fix button margins in dialogs in non-proton, r=mtigley

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2623dc64891d