Update Python used in decision task to at least 3.6
Categories
(Firefox Build System :: Task Configuration, task, P3)
Tracking
(firefox88 fixed)
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: ahal, Assigned: Callek)
References
Details
Attachments
(3 files)
I noticed the decision task is running with Python 3.5. We should bump this to at least 3.6 as this is now the minimum Python the build system supports. This will allow us to use a few extra Python features (notably f-strings) in the taskgraph.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
For posterity, from https://phabricator.services.mozilla.com/D108196#3516730 :
After some spelunking, it looks like Dustin last updated m-c's
.taskcluster.yml
with a new decision image for bug 1491371, with this patch specifically. Previous to that, I remember gps sending built docker images over. I don't know if there was automation for this or not.I think adding the automation in a CoT-verifiable way, as this patch currently does, is a good thing. Then changes to the decision image will result in CoT-verifiable builds and artifacts, and we can then choose to upload to dockerhub and update
.taskcluster.yml
with a hash-pinned image. (We will likely push tomozillareleases/gecko-decision
or similar, since Releng doesn't have access to the taskcluster namespace and the tc team is no longer maintaining these images.)
Assignee | ||
Comment 3•4 years ago
|
||
Adding leave-open so we can do Part 2 of updating the in-tree .taskcluster.yml here.
Comment 5•4 years ago
|
||
Uploaded mozillareleases/gecko_decision:3.0.0 .
3.0.0: digest: sha256:4949cc6e5faffd7caae36b624e776c20ef4c02afc2134f98f384cc46d534e6e6
size: 1155
Comment 6•4 years ago
|
||
bugherder |
Assignee | ||
Comment 7•4 years ago
|
||
(In reply to Aki Sasaki [:aki] (he/him) from comment #5)
Uploaded mozillareleases/gecko_decision:3.0.0 .
3.0.0: digest:sha256:4949cc6e5faffd7caae36b624e776c20ef4c02afc2134f98f384cc46d534e6e6
size: 1155
I should note the VERSION I updated the image in this bug was to 2.3.0 not 3.0.0, if that matters.
Assignee | ||
Comment 8•4 years ago
|
||
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D108422
Assignee | ||
Comment 10•4 years ago
|
||
For posterity, I now know how we can test the image.
#1) Push docker changes to try
#2) Wait for image to be built on try
#3) Paste the taskid of the image into the image: block of .taskcluster.yml using the correct in-tree image format:
image:
path: "public/image.tar.zst"
taskId: <taskId>
type: "task-image"
Comment 11•4 years ago
|
||
Comment 12•4 years ago
•
|
||
(In reply to Justin Wood (:Callek) from comment #7)
(In reply to Aki Sasaki [:aki] (he/him) from comment #5)
Uploaded mozillareleases/gecko_decision:3.0.0 .
3.0.0: digest:sha256:4949cc6e5faffd7caae36b624e776c20ef4c02afc2134f98f384cc46d534e6e6
size: 1155I should note the VERSION I updated the image in this bug was to 2.3.0 not 3.0.0, if that matters.
Yeah. Glad we fixed the mismatch. I bumped the major version because changing the OS version seems like a major change :)
Comment 13•4 years ago
|
||
gecko_decision:3.0.1
3.0.1: digest: sha256:9964730ed951584e65032bd1d6a2b7ede6d880a8b7aefb72d0d7f82346d834e3 size: 1364
Comment 14•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 16•4 years ago
|
||
bugherder |
Description
•