Closed Bug 1696946 Opened 3 years ago Closed 3 years ago

Suppress icons for PopupNotifications when they don't explicitly declare them

Categories

(Firefox :: Messaging System, task)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-door-hangers])

Attachments

(1 file)

Bug 1696946 - Suppress most PopupNotification notification icons when Proton is enabled. r?jaws!
48 bytes, text/x-phabricator-request
Details | Review

This will mean that when Proton is enabled, unless a PopupNotification has passed in popupIconURL or popupIconClass, that the icon rect will be collapsed. This means that any declaratively defined popupnotifications that have their icons set via CSS will need to pass in a popupIconURL or popupIconClass if they still want their icon displayed if Proton is enabled.

Whiteboard: [proton-door-hangers]
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/415e5f136485
Suppress most PopupNotification notification icons when Proton is enabled. r=jaws

https://hg.mozilla.org/mozilla-central/rev/415e5f136485

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.