1696982 - Tab mouse over highlight can't be seen with a bright color theme

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Chris Peterson [:cpeterson]]

Steps to reproduce

1. Install a light colored theme, such as "Bright Yellow" https://addons.mozilla.org/en-US/firefox/addon/bright-yellow-theme/ or "Gradientus" https://addons.mozilla.org/en-US/firefox/addon/gradientus/.
2. Mouse over the tabs.

Expected result

The tabs should have a lighter or dark color when you mouse over them.

Actual result

The mouse over highlight is so subtle can't be seen when the theme is such a bright color.

Comment 1

[Tim Nguyen :ntim]

This isn't a lot better with the non-proton theme unfortunately.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Tim Nguyen :ntim from comment #1)

This isn't a lot better with the non-proton theme unfortunately.

Yes. I forgot to unlink Proton tab bar meta bug after I discovered this is old behavior, not a Proton bug.

Comment 3

[Sam Foster [:sfoster] (he/him)]

While I agree that the tab mouseover colors tend to be pretty subtly shifted in a lot of themes, this bug isn't really actionable as-is. We don't maintain or control the themes on addons.mozilla.org so the example in comment #0 isn't a firefox bug. However, if you think its still a problem with some of our built-in themes or colorways maybe we can add better STR?

We do have to balance between highlighting the mousever state and maintaining adequate contrast between the text and background color which limits our options here. But maybe there's some defaults we could tweak?

Comment 4

[Chris Peterson [:cpeterson]]

Install a light colored theme, such as "Bright Yellow" https://addons.mozilla.org/en-US/firefox/addon/bright-yellow-theme/ or "Gradientus" https://addons.mozilla.org/en-US/firefox/addon/gradientus/.

We can close this bug. The tab highlight with the Gradientus theme is acceptable and the Bright Yellow theme is unreadable, beyond just the tab highlight.