1696997 - enable osclientcerts by default in release

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

osclientcerts is mature enough to ride the trains to release now.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1696997 - enable osclientcerts by default in release r?mbirghan

This enables the module that queries OS storage for client certificates when
TLS client authentication is requested by a server. This applies to macOS and
Windows only.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/815799bb0d7b
enable osclientcerts by default in release r=mbirghan

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/815799bb0d7b

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Firefox will automatically look for client certificates in platform-specific storage on Windows and macOS by default when necessary.
[Affects Firefox for Android]: no
[Suggested wording]: Firefox will automatically look for client certificates in platform-specific storage on Windows and macOS by default when necessary.
[Links (documentation, blog post, etc)]:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx88 beta relnotes.

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Due to bug 1695974 and bug 1699882, I think we should hold off on letting this go to release. Ryan, would it be possible to back this out of beta and nightly before we branch to release?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Sure thing. Backed out on autoland for 89+ and I'll queue it up for Beta as well.
https://hg.mozilla.org/integration/autoland/rev/6775ab7b21a8e69e6ab6b269a5eff0f344b79e09

Also removed from the Fx88 relnotes.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for 88.0b9.
https://hg.mozilla.org/releases/mozilla-beta/rev/de23ad6ffb13

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/6775ab7b21a8

Comment 10

[Dana Keeler (she/her) (use needinfo) [:keeler]]

There are no longer any show-stopping issues I'm aware of, so I'm going to re-land this.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c402eaa0284
enable osclientcerts by default in release r=mbirghan

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5c402eaa0284