Closed Bug 1697002 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27903 - [floats] Fix overlap tests in NGExclusionSpace.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27903 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27903
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[floats] Fix overlap tests in NGExclusionSpace.

In https://chromium-review.googlesource.com/c/chromium/src/+/2581885
we removed some "zero-size" shevles. I originally thought this change
was independent from the rest of the fix (this patch), but was
incorrect.

This patch fixes the "overlap" tests. It was possible to get into this
situation:

+--------------+
| Float Right |
| |
+--------------+
| Float Left |
| |
+--------------+

Here we wouldn't hit the "is_overlapping" branch when adding the "left"
exclusion.

Bug: 1156154, 1183944
Change-Id: Ife788d97d7dc6d49f0cba966cfc86719fd558f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581000
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#860300}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c41b0d5160da
[wpt PR 27903] - [floats] Fix overlap tests in NGExclusionSpace., a=testonly

https://hg.mozilla.org/mozilla-central/rev/c41b0d5160da

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.