Closed Bug 1697009 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27900 - Use test_driver.send_keys instead of test_driver.Actions.keyDown/Up

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27900 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27900
Details from upstream follow.

b'Liviu Tinta <liviutinta@chromium.org>' wrote:

Use test_driver.send_keys instead of test_driver.Actions.keyDown/Up

Fix 4 tests related to test_driver.Actions.keyDown/Up that are flaky
when using content_shell.
List of fixed tests:

  • external/wpt/pointerevents/pointerevent_touch-action-keyboard.html
  • external/wpt/editing/run/caretnavigation.html
  • external/wpt/infrastructure/testdriver/actions/elementTiming.html
  • external/wpt/css/css-scroll-snap/input/keyboard.html

Bug: 893480
Change-Id: I673229503aba4d3aa34dfa56b3cdcac6ffb4345b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2737916
Reviewed-by: Lan Wei \<lanwei@chromium.org>
Commit-Queue: Liviu Tinta \<liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#860496}

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 4
PASS : 7[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 8[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub]
FAIL : 4[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] 5[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
ERROR: 2

Chrome

OK : 6
PASS : 14

Safari

OK : 4
PASS : 5
FAIL : 7
ERROR: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-overscroll-behavior/overscroll-behavior.html: ERROR (Chrome: OK, Safari: ERROR)
/css/css-scroll-snap/input/keyboard.html
Snaps to top-left after pressing ArrowUp: FAIL (Chrome: PASS, Safari: FAIL)
Snaps to top-left after pressing ArrowLeft: FAIL (Chrome: PASS, Safari: FAIL)
If the original intended offset is valid as making a snap area cover the snapport, but there's a defined snap offset in between, use the defined snap offset.: FAIL (Chrome: PASS, Safari: FAIL)
If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is proximity, go to the original intended offset: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-scroll-snap/snap-at-user-scroll-end.html: ERROR (Chrome: OK, Safari: ERROR)
/infrastructure/testdriver/actions/elementTiming.html
TestDriver actions: element timing: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27bf5f6413d5
[wpt PR 27900] - Use test_driver.send_keys instead of test_driver.Actions.keyDown/Up, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.