1697197 - Conditional jump or move depends on uninitialised value(s) - webrender::renderer::upload::upload_to_texture_cache

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Not sure it's valid but I'm filing it anyway. Bug 1695074 may be related.
I'm getting this error while profiling video playback, more specifically a testcase from Bug 1661572.

==127580== Thread 62 Renderer:
==127580== Conditional jump or move depends on uninitialised value(s)
==127580== at 0xF8C1C97: webrender::renderer::upload::upload_to_texture_cache (upload.rs:176)
==127580== by 0xF8B731F: webrender::renderer::Renderer::update_texture_cache (mod.rs:2418)
==127580== by 0xF8AEFFE: webrender::renderer::Renderer::render_impl (mod.rs:2101)
==127580== by 0xF900AB7: wr_renderer_update (mod.rs:1447)
==127580== by 0xB59A737: mozilla::wr::RendererOGL::UpdateAndRender(mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*, mozilla::wr::RendererStats*) (gfx/webrender_bindings/RendererOGL.cpp:173)
==127580== by 0xB599E5D: mozilla::wr::RenderThread::UpdateAndRender(mozilla::wr::WrWindowId, mozilla::layers::BaseTransactionId<mozilla::VsyncIdType> const&, mozilla::TimeStamp const&, bool, mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*) (gfx/webrender_bindings/RenderThread.cpp:482)
==127580== by 0xB599A72: mozilla::wr::RenderThread::HandleFrameOneDoc(mozilla::wr::WrWindowId, bool) (gfx/webrender_bindings/RenderThread.cpp:337)
==127580== by 0xB5A09BE: applyImpl<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::)(mozilla::wr::WrWindowId, bool), StoreCopyPassByConstLRef<mozilla::wr::WrWindowId>, StoreCopyPassByConstLRef<bool> , 0, 1> (dist/include/nsThreadUtils.h:1148)
==127580== by 0xB5A09BE: apply<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::)(mozilla::wr::WrWindowId, bool)> (dist/include/nsThreadUtils.h:1154)
==127580== by 0xB5A09BE: mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void (mozilla::wr::RenderThread::)(mozilla::wr::WrWindowId, bool), true, (mozilla::RunnableKind)0, mozilla::wr::WrWindowId, bool>::Run() (dist/include/nsThreadUtils.h:1201)
==127580== by 0xACBB20D: MessageLoop::RunTask(already_AddRefed<nsIRunnable>) (ipc/chromium/src/base/message_loop.cc:468)
==127580== by 0xACBBB3F: DeferOrRunPendingTask (ipc/chromium/src/base/message_loop.cc:477)
==127580== by 0xACBBB3F: MessageLoop::DoWork() (ipc/chromium/src/base/message_loop.cc:552)
==127580== by 0xACBC160: base::MessagePumpDefault::Run(base::MessagePump::Delegate) (ipc/chromium/src/base/message_pump_default.cc:35)
==127580== by 0xACBB045: RunInternal (ipc/chromium/src/base/message_loop.cc:335)
==127580== by 0xACBB045: RunHandler (ipc/chromium/src/base/message_loop.cc:328)
==127580== by 0xACBB045: MessageLoop::Run() (ipc/chromium/src/base/message_loop.cc:310)

Comment 1

[Mike Hommey [:glandium]]

I've totally hit this when upgrading the docker image used for our valgrind jobs.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Can you take a look in gdb and try to find out what data might be unintialized?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Sure, will try.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I'm getting gdb crash when it's attached to the valgrind session so I can't investigate it further.

I'm using instructions from https://firefox-source-docs.mozilla.org/contributing/debugging/debugging_firefox_with_valgrind.html and run vgdb on the error. I can only get a backtrace but it's the same as here. I also tried non-optimized build but with the same result (gdb crashes without any meaningful info).

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Maybe you could try running address sanitizer and see if it also complains?

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Unable to reproduce with latest nightly & asan build.