1697239 - OpenPGP Aliases: Support mixed case email addresses, detect more failure scenarios

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

As reported in bug 1644085 comment 126. the implementation from bug 1644085 lacks proper handling for email addresses and aliases with uppercase/lowercase mismatch.

While working on a fix for this issue, I found additional error scenarios that we should detect and handle properly.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1697239, support mixed character case in OpenPGP aliases, better handle incorrect JSON input. r=BenC

Comment 2

[Kai Engert [:KaiE:]]

try build passed
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=d321b5d4c4dfad3d3bc56f956a5b15ce6ee14abd

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f0fe00f0d71
support mixed character case in OpenPGP aliases, better handle incorrect JSON input. r=BenC DONTBUILD

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9207826 [details]
Bug 1697239, support mixed character case in OpenPGP aliases, better handle incorrect JSON input. r=BenC

[Approval Request Comment]
Regression caused by (bug #): 1644085 (had unhandled scenarios)
User impact if declined: nonworking alias feature with uppercase/lowercase mismatch in email addresses
Testing completed (on c-c, etc.): try build, locally, automated tests
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9207826 [details]
Bug 1697239, support mixed character case in OpenPGP aliases, better handle incorrect JSON input. r=BenC

[Triage Comment]
Approved for beta (assuming no backout occurs on nightly)

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-beta/rev/1aee739bd33f7a3c1eaaa9038efaf1f19e78b243

Comment 7

[Andreas Greulich]

Works now, thanks a lot :+1:

Comment 8

[Kai Engert [:KaiE:]]

Comment on attachment 9207826 [details]
Bug 1697239, support mixed character case in OpenPGP aliases, better handle incorrect JSON input. r=BenC

[Approval Request Comment]
Regression caused by (bug #): 1644085
User impact if declined: required follow-up fix for bug 1644085
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9207826 [details]
Bug 1697239, support mixed character case in OpenPGP aliases, better handle incorrect JSON input. r=BenC

[Triage Comment]
Approved for esr78

Comment 10

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/8caaab0fb7318c8911386b05818f7147ee8c1b25
78.9.1