1697243 - The icons of the Themes and Density drop-down buttons look really bad in High Contrast Mode on macOS 11

Status: REOPENED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Attachment: Themes and Density drop-down button icons are overflowing.png

Note

• When the user reaches the Customise screen, he will notice

Affected versions

• Nightly v88.0a1
• Beta v87.0b7
• Release v86.0 is unaffected

Affected platforms

• MacBook Air 2013; Mac OS 11.2; display aspect ratio of 16:10, resolution 1440x900.
• not reproducible on MacMini 2011; Mac OS 10.13.6 (most probably) detects the compatible aspect ratio and resolution of the connected monitor; mine has 16x9 and resolution 1920 x 1080.

Steps to reproduce

1. Launch browser.
2. Open Hamburger Menu.
3. Click Customize Toolbar...

Expected result

• The icons of the Density and Themes buttons aren't overflowing.

Actual result

• The icons of the Density and Themes buttons ARE overflowing.

Regression range

• I could not investigate for the regressor because mozregression does not work on Mac OS 11.
• It is highly possible this was introduced with Proton code.

Comment 1

[Daniel Bodea [:danibodea]]

Correction.

Comment 2

[:Gijs (out for now; he/him)]

[Tracking Requested - why for this release]:
The buttons just look bad. I don't know why. We should ideally not ship this.

(In reply to Bodea Daniel [:danibodea] from comment #0)

• I could not investigate for the regressor because mozregression does not work on Mac OS 11.

I'm pretty sure the commandline version should work. If not, can you link to the bug on file that covers what is broken?

• It is highly possible this was introduced with Proton code.

Markus, this looks like a native menu button styling regression to me (where the height of the buttons with icons is no longer respected). Can you take a look? I don't have access to macOS 11 myself or I would check myself...

Comment 4

[Markus Stange [:mstange]]

Attachment: what I see

Comment 5

[Markus Stange [:mstange]]

Ah, high contrast mode is part of STR here.

Reopening because there's surely a way to make this look better in high contrast mode. For example, it looks like the buttons are using the small control size rather than the regular control size.

Comment 6

[:Gijs (out for now; he/him)]

If this is specific to HCM in macOS 11 it probably doesn't need to block 87 so downgrading severity and marking wontfix for 87.