Closed
Bug 1697320
Opened 4 years ago
Closed 4 years ago
webrender::render_task_graph::dump_render_tasks_as_svg should not be marked #[allow(dead_code)]
Categories
(Core :: Graphics: WebRender, defect, P4)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
The reason Rust didn't warn us that RenderPass::tasks was unused (bug 1695908) is that dump_render_tasks_as_svg contains a use of that field, and is marked as #[allow(dead-code)]. If it were instead marked #[cfg(feature = "capture")], then Rust could have warned us about the dead field in non-capture builds.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/537e54c210e7
Mark webrender::render_task_graph::dump_render_tasks_as_svg as needed only when 'capture' feature is enabled r=nical
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•