1697338 - Make context menus, tooltips, and vibrant sidebars adapt to the system appearance, if widget.respect-system-appearance is set to true

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P1)

Description

[Markus Stange [:mstange]]

Our tooltips and context menus currently have their vibrancy set to "always light" regardless of the system appearance. This causes clashes once we stop forcing the aqua theme, because then the text color does respect the system appearance, and we get white text on light menus / tooltips.

So this bug is about using the system appearance for tooltip and menu vibrancy. This will not change anything for our users until bug 1623686 is also fixed. But we can't fix bug 1623686 without making this work.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1697338 - WIP: Make context menus and tooltips adapt to the system theme, if widget.macos.respect-system-appearance is set to true.

TODO: fontsmoothing-background-colors need tweaking

Depends on D107750

Comment 2

[Markus Stange [:mstange]]

Attachment: command line executable to dump out font smoothing background colors for the various vibrancy types

This is a new version of attachment 8907533 [details] (from bug 1387594).

Comment 3

[Markus Stange [:mstange]]

Attachment: output on 10.14

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1697338 - Remove unused -moz-default-appearance values -moz-mac-vibrancy-light/dark, and the system colors of the same name. r=emilio

Starting with macOS 10.14, the generic light/dark vibrancy is deprecated, and semantic vibrancy names are preferred.
If we ever need more vibrancy, we can add new values with semantic names.

Depends on D107910

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1697338 - Rename VibrancyType::LIGHT/DARK to TITLEBAR_LIGHT/DARK. r=#mac-reviewers

Depends on D108152

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1697338 - Use semantic vibrancy material names for all vibrancy types, and stop using the appearance-based material which is deprecated. r=#mac-reviewers

Depends on D108153

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1697338 - Make context menus and tooltips adapt to the system appearance, if widget.macos.respect-system-appearance is set to true. r=#mac-reviewers

With this patch, we will no longer use the vibrant appearance names on 10.14+,
as suggested in the 10.14 release notes:

For apps linked against the macOS 10.14 SDK, NSVisualEffectView automatically
uses the correct vibrant NSAppearance as its appearance, based on the
appearance of its superview. For example, if its superview uses the aqua
appearance, NSVisualEffectView uses vibrantLight. As a result, you shouldn’t
explicitly set the appearance of the NSVisualEffectView, either in code or in
Interface Builder. Explicitly setting the appearance was necessary in earlier
versions of macOS."

The above applies to us even while we still link to the 10.12 SDK, because we
now set the "requires aqua appearance" plist flag to false (since bug 1697331).

Depends on D108154

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1697338 - Update font-smoothing background colors, and make them respect dark mode. r=emilio

Depends on D108155

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4712efb9a443
Remove unused -moz-default-appearance values -moz-mac-vibrancy-light/dark, and the system colors of the same name. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c7bcee7946f0
Rename VibrancyType::LIGHT/DARK to TITLEBAR_LIGHT/DARK. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/00d4d012adfe
Use semantic vibrancy material names for all vibrancy types, and stop using the appearance-based material which is deprecated. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/167d55a97ce8
Make context menus and tooltips adapt to the system appearance, if widget.macos.respect-system-appearance is set to true. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/caac819bb7ee
Update font-smoothing background colors, and make them respect dark mode. r=emilio

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4712efb9a443
https://hg.mozilla.org/mozilla-central/rev/c7bcee7946f0
https://hg.mozilla.org/mozilla-central/rev/00d4d012adfe
https://hg.mozilla.org/mozilla-central/rev/167d55a97ce8
https://hg.mozilla.org/mozilla-central/rev/caac819bb7ee