1697341 - Remove "sheet" vibrancy

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P1)

Description

[Markus Stange [:mstange]]

We currently have some custom vibrancy code to give sheet windows a blurred appearance.

This code is no longer needed. The regular window background for sheet windows draws the blur, and the window content drawn by Gecko is transparent, so the blur shines through.

There is one caveat: On 10.14 and above, as long as we force the aqua appearance, there is no default blur. But once we stop forcing the aqua appearance, the blur is back. So this means that we'll have a window without sheet blur between the time when this bug lands and the time when bug 1623686 lands.

Furthermore, removing our custom sheet window vibrancy is required to make sheet windows adapt to Dark Mode (and not clash with white text), so we actually have to do this before we can land bug 1623686.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1697341 - Remove vibrancy code for sheet windows. r=spohl

With -moz-appearance: dialog now always being transparent, setting up our own
vibrant views for sheet windows is no longer necessary. We now let the regular
sheet window background show through, and that background is already vibrant.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ccb7fa94f32
Remove vibrancy code for sheet windows. r=spohl

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1ccb7fa94f32