1697346 - Remove snapping of inflated surface rects

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1697346 - Remove snapping of inflated surface rects.

When an offscreen surface establishes a raster root, this code
was causing incorrect snapping / rounded (even on non-inflated
surfaces), resulting in test failures in some cases.

In theory, this should not be necessary, since scroll offsets are
snapped, and primitives are already snapped during scene building.
Additionally, the picture surface allocation code expects surfaces
with fractional offsets and handles this case (by rounding out the
allocation size, and creating a UV set that samples from the subpixel
offsets of the surface).

In practice, there may be content that relies on this which isn't
tested by CI, so let's land this as a separate patch and see if it
causes any real-world content regressions, before landing the
changes that rely on this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7647c3e90bed
Remove snapping of inflated surface rects. r=aosmond,gfx-reviewers

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 7647c3e90bed (bug 1697346) for Wrench failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=332784769&repo=autoland&lineNumber=13338

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=7647c3e90bedc40aca04283df9c74ec9da52ef18

Backout:
https://hg.mozilla.org/integration/autoland/rev/a308004e1334c349d633c80340b017cfaf6111e9

Comment 4

[Glenn Watson [:gw]]

Added an extra 3 pixels of fuzziness for that test, will try and re-land now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c91811dabc6
Remove snapping of inflated surface rects. r=aosmond,gfx-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5c91811dabc6