Use a single waitForDispatch test helper and move it to devtools shared-head.js
Categories
(DevTools :: General, task, P3)
Tracking
(firefox88 fixed)
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Several DevTools test suites implement their own waitForDispatch helpers:
https://searchfox.org/mozilla-central/search?q=function+waitForDispatch&path=devtools
We have currently 8 different implementations, we should try to consolidate to a single implementation and move it to shared-head.js.
There are some minor differences; for instance some methods are expecting a generic store argument while others expect a panel argument and extract the store from it. But there also some potentially more impacting differences, such as the handling of async actions, and support for action count.
Assignee | ||
Comment 1•4 years ago
|
||
Depends on D107675
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
One of the problems with those async actions is that the states are panel specific. Debugger uses "error" & "done", while DOM uses "error" & "end". We can make the generic helper support all possible states, or we could unify all our redux codebase to use the same status strings.
Comment 4•4 years ago
|
||
bugherder |
Description
•