Closed Bug 1697403 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27876 - [ResourceTiming] Refactor assertions in entry-attributes.html

Categories

(Core :: Performance, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27876 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27876
Details from upstream follow.

b'Tom McKee <tommckee@chromium.org>' wrote:

[ResourceTiming] Refactor assertions in entry-attributes.html

The ResourceTiming spec describes the expected values for the attributes
of PerformanceResourceTiming objects. The expected values follow a
common pattern when the resource is fetched in particular ways like over
HTTP or when the Timing-Allow-Origin header doesn't match.

This change refactors a collection of assertions over one of these
patterns into a helper function: assert_http_resource().

Bug: 1171767
Change-Id: I9e7aee031f65439fd36d58b480f0709d0a5ea5b5
GithubIssue: https://github.com/w3c/resource-timing/issues/254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2732507
Commit-Queue: Tom McKee \<tommckee@chromium.org>
Reviewed-by: Yoav Weiss \<yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861163}

PR 27876 applied with additional changes from upstream: bd23e127fcc1456779eded21dda1c1dac66fc1d9
Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/047749903e6c [wpt PR 27876] - [ResourceTiming] Refactor assertions in entry-attributes.html, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.