1697424 - Some buttons are changing their style in "Customize Toolbar" with Increased Constrast enabled on MAC OsX

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Rares Doghi, Desktop QA]

[Affected versions]
Beta 87
Nightly 88

[Affected platforms]
Mac OsX

[Steps to reproduce]

1. Open the Firefox browser and open the Hamburger menu.
2. Reach the Customize Toolbar page.

[Expected result]
The Toolbar, Themes and Density buttons should not change their style when Increased Contrast is enabled on MAC

[Actual result]
The Toolbar , Themes and Density buttons are changing their style when Increased Contrast is enabled on MAC

Regression range :
19:19.80 INFO: Last good revision: 66ae0882ef558ea8b94c8855daaa0bc1a8f442b0
19:19.80 INFO: First bad revision: 5cbcb80f72bd7606c8572aa89247235ddcbd7762
19:19.80 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=66ae0882ef558ea8b94c8855daaa0bc1a8f442b0&tochange=5cbcb80f72bd7606c8572aa89247235ddcbd7762

It seems that Bug 1691965 might cause the issue here.

Comment 1

[Rares Doghi, Desktop QA]

Hi Tim, can you please take a look at this?

Comment 2

[Dão Gottwald [:dao]]

Could you please add before and after screenshots?

Comment 3

[Tim Nguyen :ntim]

Attachment: New high contrast footer for customize mode on macOS

I was aware of this change, but I don't think it's a bug by itself?

I guess I can increase the size of the buttons? this looks bad for the buttons (macOS or Gecko pushes some non-native styles)

Comment 4

[Tim Nguyen :ntim]

Attachment: Before

Dão, wdyt? I can back out the relevant part if the result isn't wanted. The other bits of the patch should be OK otherwise.

Fwiw, high contrast mode on macOS is darker borders, no vibrancy effects and slightly more contrasting colors.

Comment 5

[Dão Gottwald [:dao]]

Yeah, so this is expected and an improvement for high contrast.