1697477 - Expose a property on nsISearchEngine to indicate general web search engines

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1695262 we are adding a hard-coded list of general search engines (as opposed to ones for specific things, e.g. shopping), which we might fallback to if the default engine is removed - see the bug for exact details.

In bug 1647889 the address bar added a similar list of hard-coded engines.

From my discussions around bug 1695262, we had decided that at some stage we would like to move the list out to WebExtension metadata, but we weren't ready for it yet as we think we would want more categories than just general but we haven't done enough thinking yet to know what we want there.

I think we should handle moving the lists out to WebExtension metadata in bug 1658661.

For now, I think we should add an isGeneral or maybe isWebEngine property to nsISearchEngine and consolidate the two lists within it.

This would also give us a stepping stone to make it easier when we do add the WebExtension metadata.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1697477 - Expose a property on nsISearchEngine to indicate general web search engines. r?daleharvey!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1697477 - Use the new nsISearchEngine.isWebEngine property in the urlbar. r?mak!

Depends on D109547

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=ddf4d12aee2587a30c0774c8d256176a24fa8f97

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/250b2f89c925
Expose a property on nsISearchEngine to indicate general web search engines. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/1fe2e308300f
Use the new nsISearchEngine.isWebEngine property in the urlbar. r=mak

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/250b2f89c925
https://hg.mozilla.org/mozilla-central/rev/1fe2e308300f