169756 - password fields should be part of tab cycle when textfield-only option is set

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2002.09.19.08 comm trunk builds. when the pref
"accessibility.tabfocus" is set to 1 (tab only btwn textfields within a page),
password fields are left out of the cycle.

this is most evident on mac and linux, where the default for that pref is 1. see
bug 140612 for details on the pref.

1. go to a page with a username and passwd field, eg, http://calendar-1.mcom.com
2. bring focus to the Name field (need to mouseclick when the pref is 1).
3. try to tab to the Password field.

results: the cursor disappears --it doesn't move to the passwd field. btw, if i
hit tab a second time, the cursor just reappears in the username field.

if i have focus in the passwd field and hit shift-tab instead, however, then
focus moves back to the username field --expected, since we're moving into a
type=text field.

Comment 1

[sairuh (rarely reading bugmail)]

nominating.

Comment 2

[sairuh (rarely reading bugmail)]

another site: http://my.yahoo.com/

Comment 3

[sairuh (rarely reading bugmail)]

see also bug 169767, for application windows being affected.

Comment 4

[sairuh (rarely reading bugmail)]

*** Bug 169776 has been marked as a duplicate of this bug. ***

Comment 5

[Akkana Peck]

This one, fortunately, turns out to be much simpler than bug 169767.  Simple
patch to follow.

Comment 6

[Akkana Peck]

Attachment: Full patch with a bunch of formatting-whitespace changes

Here's the fix as it sits in my tree.  This version of the patch also includes
a lot of formatting changes, because it turns out that I checked in the -w
version of the previous fix (oops!), so reviewers will probably want to skip
this one and review the -w version I'm about to attach.

Comment 7

[Akkana Peck]

Attachment: Minimal patch (-w): check for input type=password as well as text

Here is the minimal version of the patch, with -w, on which I'm seeking review.

(It includes one whitespace change, fixing a long line.)

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 99926 [details] [diff] [review]
Minimal patch (-w): check for input type=password as well as text

r=glazman

Comment 9

[Akkana Peck]

If either Simon or Bryner is around tonight and willing to sr, we could get the
password fix in for tomorrow morning's builds ...

Comment 10

[Simon Fraser [no longer active]]

Comment on attachment 99926 [details] [diff] [review]
Minimal patch (-w): check for input type=password as well as text

sr=sfraser

Comment 11

[Akkana Peck]

Thanks for the quick reviews!  Fix is in.

Comment 12

[sairuh (rarely reading bugmail)]

yay! vrfy'd fixed on mac 10.2 and linux rh7.2, 2002.09.20 mozilla trunk builds.

Comment 13

[sairuh (rarely reading bugmail)]

*** Bug 169974 has been marked as a duplicate of this bug. ***