Open Bug 1697586 Opened 4 years ago Updated 4 years ago

Multi-selected tabs becomes de-selected when opening context menu using ctrl+click

Categories

(Firefox :: Tabbed Browser, defect)

Firefox 88
Desktop
macOS
defect

Tracking

()

Tracking Status
firefox88 --- affected

People

(Reporter: amylee, Unassigned)

Details

In Nightly 88.0a1 (2021-03-11) using a Macbook Pro

Steps to reproduce:

  1. Hold shift and using trackpad (or mouse) multi-select opened tabs
  2. Hold ctrl and tap on trackpad on any selected tab

Expected:
Context menu opens with multi-selected tabs still selected

Actual:
Only the tab that the context menu opened from is selected and other tabs are deselected

I haven't tested this on a PC laptop so not sure if the issue is also there

Summary: Multi-selected tabs become de-selected when opening context menu using trackpad → Multi-selected tabs becomes de-selected when opening context menu using trackpad

The macOS widget code for Ctrl+click fires mousedown before it fires contextmenu. That first mousedown is probably what causes the selection to be reset.

Here's a comment which claims that "Gecko [...] expects the mouse down event before the context menu event":
https://searchfox.org/mozilla-central/rev/a848cde8a73065fcc41902ac58c65821eb9a44ca/widget/cocoa/nsChildView.mm#3470-3473
This code is 13 years old so it's probably worth revisiting.

Summary: Multi-selected tabs becomes de-selected when opening context menu using trackpad → Multi-selected tabs becomes de-selected when opening context menu using ctrl+click
You need to log in before you can comment on or make changes to this bug.