1697597 - Save to Pocket button home panel for newtab and other non link contexts

Status: VERIFIED FIXED

(Firefox :: Pocket, enhancement, P2)

Description

[Scott [:thecount] Downe]

Right now the save to Pocket button doesn't show for newtab.

If we had a panel for displaying something that makes sense here, we could enable it.

The contents of the panel would be a link to your Pocket account, your list, and some popular topics.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1697597 - Adding a Pocket button home view

Comment 2

[Scott [:thecount] Downe]

Attachment: data review request

Comment 3

[klong]

Comment on attachment 9215492 [details]
data review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

https://phabricator.services.mozilla.com/D111185
-> browser/components/newtab/docs/v2-system-addon/data_events.md file

https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/data_events.html#save-to-pocket-button-pings

Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes. Users can opt-out the data collection by disabling the Firefox telemetry.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kirill Demtchouk ([e-mail]) will be monitoring those metrics.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

These bug falls under Category 2.

Is the data collection request for default-on or default-off?

Default on for all channels and countries/locales.

Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

Does the data collection use a third-party collection tool?

No.

Comment 4

[Scott [:thecount] Downe]

Steps to test:

1. Go to newtab.
2. Click the Pocket button.

Expected: should show a home panel, with a link to your pocket list, topic links, and a discover more link.

Things to note:

1. there is telemetry for the button clicks.
2. non English browsers don't have topics or discover more.
3. there is a pref to turn this off if we need to, but it's on by default.
4. rtl should work just fine.
5. local builds need to be non artifact builds for this patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17a943da18dc
Adding a Pocket button home view r=gvn,flod

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/17a943da18dc

Comment 7

[Robert Martin [:romartin], Ecosystem QA]

This enhancement was verified as part of the work done for the "PI-1008 Update Pocket Save Butoon Doorhanger" feature.