Closed Bug 1697648 Opened 4 years ago Closed 4 years ago

Warp: Fix scalar replacement of arrays

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1650233

People

(Reporter: iain, Assigned: iain)

Details

Because it is based on transpiling CacheIR guards instead of using TI, WarpBuilder generates slightly different MIR than IonBuilder did. Some of the changes broke scalar replacement of arrays: in particular, every LoadElement is now conservatively marked as needsHoleCheck, which prevents scalar replacement. We should fix that.

I investigated this before in bug 1650233. Good to see this getting fixed!

Oh, right, I forgot we already had a bug. Closing this as a dupe.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.