1697667 - [wpt-sync] Sync PR 27974 - [LayoutNG] Fix order OOFs are added in

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27974 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27974
Details from upstream follow.

b'Alison Maher <[e-mail]>' wrote:

[LayoutNG] Fix order OOFs are added in

We were adding OOFs to columns in an incorrect order. Instead of
simply looking at IsFirstForNode(), we have to look at the order of
the child break tokens in the incoming column break token. This CL
updates NGSimplifiedOOFLayoutAlgorithm to look at incoming break
tokens to determine this order.

Bug: 1079031
Change-Id: I03e627abd431df259affc42a2414ef2a123a3444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2746814
Reviewed-by: Morten Stenshorne \<[e-mail]>
Commit-Queue: Alison Maher \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#861707}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=20a7f205f9fd8b660dbdc9d83da98de2d6115084

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/out-of-flow-in-multicolumn-015.html: FAIL

New Tests That Don't Pass

/css/css-break/out-of-flow-in-multicolumn-015.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/out-of-flow-in-multicolumn-021.html: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7975fc877d0f
[wpt PR 27974] - [LayoutNG] Fix order OOFs are added in, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f4200c4f0139
[wpt PR 27974] - Update wpt metadata, a=testonly

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7975fc877d0f
https://hg.mozilla.org/mozilla-central/rev/f4200c4f0139