Closed Bug 1697709 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27956 - v8bindings: Enable the fix of cross origin window name visibility

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27956 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27956
Details from upstream follow.

b'Yuki Shiino <yukishiino@chromium.org>' wrote:

v8bindings: Enable the fix of cross origin window name visibility

Enables the fix of cross origin window name visibility in
production.

This fix was once applied back in 2017, but got reverted due to
a bug in youtube.com (not because the fix was wrong). We've been
disabling the fix since then. The bug in youtube.com was fixed
many years ago, so nothing should prevent us to enable the fix now.

https://chromestatus.com/metrics/feature/timeline/popularity/1872
shows the affected cases of this fix as 0.045% of page loads.
So, we shouldn't hit the same severe trouble like the one of
youtube.com in the past.

Bug: 538562
Change-Id: Ia28090493c2eb1f67d65de52f64690bb755ed38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734200
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Reviewed-by: Kentaro Hara \<haraken@chromium.org>
Commit-Queue: Yuki Shiino \<yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861825}

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb6f6e1be019
[wpt PR 27956] - v8bindings: Enable the fix of cross origin window name visibility, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.