Closed Bug 1697711 Opened 4 years ago Closed 4 years ago

Permafailing [fg] 0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL

Categories

(Toolkit :: General, defect, P5)

defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bigiri)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Filed by: dluca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=332745082&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/F_ExVLuxTo6otOiLSUgG2g/runs/0/artifacts/public/logs/live_backing.log


 0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestHyphensToCamelCase::test_simple_cases PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestExceptionGroup::test_str_indentation_of_grouped_lines PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_repr_no_file PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_repr_with_file PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_str_no_file PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_str_with_file PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_empty_feature PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_invalid_toml PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_missing_file PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL
[task 2021-03-10T20:32:46.421Z]  0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_extra_keys_not_allowed PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_minimal_valid PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_nonempty_keys PASSED
[task 2021-03-10T20:32:46.421Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_required_fields PASSED
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_default_value_default TEST-UNEXPECTED-FAIL
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_default_value_override_configured_value PASSED
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_default_value_override_constant PASSED
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_hyphenation_to_snake_case PASSED
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_preference_default PASSED
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_preference_override PASSED
[task 2021-03-10T20:32:46.422Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_compound_keys PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_default_key_is_required PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_expands_single_values PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_invalid_keys_rejected PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_multiple_keys PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_simple_key PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::MainTests::test_it_outputs_json TEST-UNEXPECTED-FAIL
[task 2021-03-10T20:32:46.423Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::MainTests::test_it_returns_1_for_errors PASSED
[task 2021-03-10T20:32:46.423Z]  0:06.69 
[task 2021-03-10T20:32:46.423Z]  0:06.69 =================================== FAILURES ===================================
[task 2021-03-10T20:32:46.424Z]  0:06.69 _______________________ TestProcessFiles.test_valid_file _______________________
[task 2021-03-10T20:32:46.424Z]  0:06.69 
[task 2021-03-10T20:32:46.424Z]  0:06.69 self = <test_gen_feature_definitions.TestProcessFiles testMethod=test_valid_file>
[task 2021-03-10T20:32:46.424Z]  0:06.69 
[task 2021-03-10T20:32:46.424Z]  0:06.69     def test_valid_file(self):
[task 2021-03-10T20:32:46.424Z]  0:06.69         filename = make_test_file_path("good")
[task 2021-03-10T20:32:46.424Z]  0:06.69         result = process_files([filename])
[task 2021-03-10T20:32:46.424Z]  0:06.69 >       assert result == {
[task 2021-03-10T20:32:46.424Z]  0:06.69             "demo-feature": {
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "id": "demo-feature",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "title": "Demo Feature",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "description": "A no-op feature to demo the feature gate system.",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "restartRequired": False,
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "preference": "foo.bar.baz",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "type": "boolean",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "bugNumbers": [1479127],
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "isPublic": {"default": True},
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "defaultValue": {"default": False},
[task 2021-03-10T20:32:46.424Z]  0:06.69             },
[task 2021-03-10T20:32:46.424Z]  0:06.69             "minimal-feature": {
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "id": "minimal-feature",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "title": "Minimal Feature",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "description": "The smallest feature that is valid",
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "restartRequired": True,
[task 2021-03-10T20:32:46.424Z]  0:06.69                 "preference": "features.minimal-feature.enabled",
[task 2021-03-10T20:32:46.425Z]  0:06.69                 "type": "boolean",
[task 2021-03-10T20:32:46.425Z]  0:06.69                 "bugNumbers": [1479127],
[task 2021-03-10T20:32:46.425Z]  0:06.69                 "isPublic": {"default": False},
[task 2021-03-10T20:32:46.425Z]  0:06.69                 "defaultValue": {"default": False},
[task 2021-03-10T20:32:46.425Z]  0:06.69             },
[task 2021-03-10T20:32:46.425Z]  0:06.69         }
[task 2021-03-10T20:32:46.425Z]  0:06.69 E       AssertionError: assert {'demo-featur...eature', ...}} == {'demo-feature...eature', ...}}
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         Common items:
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         {'demo-feature': {u'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'defaultValue': {'default': False},
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'description': u'A no-op feature to demo the feature gate system.',
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           'id': u'demo-feature',
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'isPublic': {'default': True},
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'preference': u'foo.bar.baz',
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'restartRequired': False,
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'title': u'Demo Feature',
[task 2021-03-10T20:32:46.425Z]  0:06.69 E                           u'type': u'boolean'}}
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         Differing items:
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         {'minimal-feature': {'bugNumbers': [1479127], 'defaultValue': {'default': None}, 'description': 'The smallest feature that is valid', 'id': 'minimal-feature', ...}} != {'minimal-feature': {'bugNumbers': [1479127], 'defaultValue': {'default': False}, 'description': 'The smallest feature that is valid', 'id': 'minimal-feature', ...}}
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         Full diff:
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         - {u'demo-feature': {u'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         ?  -                 -
[task 2021-03-10T20:32:46.425Z]  0:06.69 E         + {'demo-feature': {'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.426Z]  0:06.69 E         -                    u'defaultValue': {'default': False},
[task 2021-03-10T20:32:46.426Z]  0:06.69 E         ?                   --
[task 2021-03-10T20:32:46.426Z]  0:06.69 E         +                   'defaultValue': {'default': False},
[task 2021-03-10T20:32:46.426Z]  0:06.69 E         -                    u'description': u'A no-op feature to demo the feature gate system.',
[task 2021-03-10T20:32:46.426Z]  0:06.69 E         ?                   --               -
[task 2021-03-10T20:32:46.426Z]  0:06.69 E         +                   'description': 'A no-op feature to demo the feature gate system.',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                    'id': u'demo-feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ? -                        -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                   'id': 'demo-feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                    u'isPublic': {'default': True},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                   --
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                   'isPublic': {'default': True},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                    u'preference': u'foo.bar.baz',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                   --              -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                   'preference': 'foo.bar.baz',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                    u'restartRequired': False,
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                   --
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                   'restartRequired': False,
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                    u'title': u'Demo Feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                   --         -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                   'title': 'Demo Feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                    u'type': u'boolean'},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                   --        -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                   'type': 'boolean'},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -  u'minimal-feature': {u'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?  -                    -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +  'minimal-feature': {'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       'defaultValue': {'default': None},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ? -                                                 ^^^
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'defaultValue': {'default': False},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                                                  ^^^^
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       u'description': u'The smallest feature that is valid',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                      --               -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'description': 'The smallest feature that is valid',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       'id': u'minimal-feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ? -                           -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'id': 'minimal-feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       'isPublic': {'default': False},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ? -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'isPublic': {'default': False},
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       'preference': 'features.minimal-feature.enabled',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ? -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'preference': 'features.minimal-feature.enabled',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       u'restartRequired': True,
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                      --
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'restartRequired': True,
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       u'title': u'Minimal Feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                      --         -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'title': 'Minimal Feature',
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         -                       u'type': u'boolean'}}
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?                      --        -
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         +                      'type': 'boolean'}}
[task 2021-03-10T20:32:46.427Z]  0:06.69 
[task 2021-03-10T20:32:46.427Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py:109: AssertionError
[task 2021-03-10T20:32:46.427Z]  0:06.69 ________________ ExpandFeatureTests.test_default_value_default _________________
[task 2021-03-10T20:32:46.427Z]  0:06.69 
[task 2021-03-10T20:32:46.427Z]  0:06.69 self = <test_gen_feature_definitions.ExpandFeatureTests testMethod=test_default_value_default>
[task 2021-03-10T20:32:46.427Z]  0:06.69 
[task 2021-03-10T20:32:46.427Z]  0:06.69     def test_default_value_default(self):
[task 2021-03-10T20:32:46.427Z]  0:06.69         feature = minimal_definition(type="boolean")
[task 2021-03-10T20:32:46.427Z]  0:06.69         assert "default-value" not in feature
[task 2021-03-10T20:32:46.427Z]  0:06.69         assert "defaultValue" not in feature
[task 2021-03-10T20:32:46.427Z]  0:06.69 >       assert expand_feature(feature)["defaultValue"] == {"default": False}
[task 2021-03-10T20:32:46.427Z]  0:06.69 E       AssertionError: assert {'default': None} == {'default': False}
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         Differing items:
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         {'default': None} != {'default': False}
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         Full diff:
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         - {'default': None}
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?             ^^^
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         + {'default': False}
[task 2021-03-10T20:32:46.427Z]  0:06.69 E         ?             ^^^^
[task 2021-03-10T20:32:46.427Z]  0:06.69 
[task 2021-03-10T20:32:46.427Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py:219: AssertionError
[task 2021-03-10T20:32:46.427Z]  0:06.69 ________________________ MainTests.test_it_outputs_json ________________________
[task 2021-03-10T20:32:46.427Z]  0:06.69 
[task 2021-03-10T20:32:46.427Z]  0:06.69 self = <test_gen_feature_definitions.MainTests testMethod=test_it_outputs_json>
[task 2021-03-10T20:32:46.427Z]  0:06.69 
[task 2021-03-10T20:32:46.427Z]  0:06.69     def test_it_outputs_json(self):
[task 2021-03-10T20:32:46.427Z]  0:06.69         output = StringIO()
[task 2021-03-10T20:32:46.427Z]  0:06.69         filename = make_test_file_path("good")
[task 2021-03-10T20:32:46.427Z]  0:06.69         main(output, filename)
[task 2021-03-10T20:32:46.427Z]  0:06.69         output.seek(0)
[task 2021-03-10T20:32:46.427Z]  0:06.69         results = json.load(output)
[task 2021-03-10T20:32:46.427Z]  0:06.69 >       assert results == {
[task 2021-03-10T20:32:46.428Z]  0:06.69             u"demo-feature": {
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"id": u"demo-feature",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"title": u"Demo Feature",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"description": u"A no-op feature to demo the feature gate system.",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"restartRequired": False,
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"preference": u"foo.bar.baz",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"type": u"boolean",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"bugNumbers": [1479127],
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"isPublic": {u"default": True},
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"defaultValue": {u"default": False},
[task 2021-03-10T20:32:46.428Z]  0:06.69             },
[task 2021-03-10T20:32:46.428Z]  0:06.69             u"minimal-feature": {
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"id": u"minimal-feature",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"title": u"Minimal Feature",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"description": u"The smallest feature that is valid",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"restartRequired": True,
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"preference": u"features.minimal-feature.enabled",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"type": u"boolean",
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"bugNumbers": [1479127],
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"isPublic": {u"default": False},
[task 2021-03-10T20:32:46.428Z]  0:06.69                 u"defaultValue": {u"default": False},
[task 2021-03-10T20:32:46.428Z]  0:06.69             },
[task 2021-03-10T20:32:46.428Z]  0:06.69         }
[task 2021-03-10T20:32:46.428Z]  0:06.69 E       AssertionError: assert {'demo-featur...eature', ...}} == {'demo-feature...eature', ...}}
[task 2021-03-10T20:32:46.428Z]  0:06.69 E         Common items:
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         {u'demo-feature': {u'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'defaultValue': {u'default': False},
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'description': u'A no-op feature to demo the feature gate system.',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'id': u'demo-feature',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'isPublic': {u'default': True},
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'preference': u'foo.bar.baz',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'restartRequired': False,
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'title': u'Demo Feature',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E                            u'type': u'boolean'}}
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         Differing items:
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         {'minimal-feature': {'bugNumbers': [1479127], 'defaultValue': {'default': None}, 'description': 'The smallest feature that is valid', 'id': 'minimal-feature', ...}} != {'minimal-feature': {'bugNumbers': [1479127], 'defaultValue': {'default': False}, 'description': 'The smallest feature that is valid', 'id': 'minimal-feature', ...}}
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         Full diff:
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         {u'demo-feature': {u'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'defaultValue': {u'default': False},
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'description': u'A no-op feature to demo the feature gate system.',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'id': u'demo-feature',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'isPublic': {u'default': True},
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'preference': u'foo.bar.baz',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'restartRequired': False,
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'title': u'Demo Feature',
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'type': u'boolean'},
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         u'minimal-feature': {u'bugNumbers': [1479127],
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         -                       u'defaultValue': {u'default': None},
[task 2021-03-10T20:32:46.429Z]  0:06.69 E         ?                                                     ^^^
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         +                       u'defaultValue': {u'default': False},
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         ?                                                     ^^^^
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'description': u'The smallest feature that is valid',
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'id': u'minimal-feature',
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'isPublic': {u'default': False},
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'preference': u'features.minimal-feature.enabled',
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'restartRequired': True,
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'title': u'Minimal Feature',
[task 2021-03-10T20:32:46.430Z]  0:06.69 E         u'type': u'boolean'}}
[task 2021-03-10T20:32:46.430Z]  0:06.69 
[task 2021-03-10T20:32:46.430Z]  0:06.69 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py:279: AssertionError
[task 2021-03-10T20:32:46.430Z]  0:06.69 ===================== 3 failed, 25 passed in 0.11 seconds ======================
[task 2021-03-10T20:32:46.430Z]  0:06.69 Setting retcode to 1 from /builds/worker/checkouts/gecko/toolkit/components/featuregates/test/python/test_gen_feature_definitions.py
[task 2021-03-10T20:32:46.431Z]  0:06.70 Return code from mach python-test: 1
[taskcluster 2021-03-10 20:32:47.174Z] === Task Finished ===
[taskcluster 2021-03-10 20:32:47.174Z] Unsuccessful task run with exit code: 1 completed in 25.68 seconds```

Set release status flags based on info from the regressing bug 1692122

Summary: Intermittent [fg] 0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL → Permafailing [fg] 0:06.68 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL
Flags: needinfo?(bigiri)
Assignee: nobody → bigiri
Flags: needinfo?(bigiri)

Updating python test to reflect changes to default values in features.

Status: NEW → ASSIGNED
Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30603a26d211 Fixing test_gen_feature_definitions.py test failure r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

After the fix landed, the jobs started failing in TestFeatureGateException.

Gijs, should we make a new bug for this issue, or does it have the same root cause as the one discussed in this bug?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Alexandru Michis [:malexandru] from comment #5)

After the fix landed, the jobs started failing in TestFeatureGateException.

Gijs, should we make a new bug for this issue, or does it have the same root cause as the one discussed in this bug?

I don't know so let's default to a new bug.

Flags: needinfo?(gijskruitbosch+bugs)

Ni for previous comment. :-)

Flags: needinfo?(malexandru)
See Also: → 1699210

Made Bug 1699210 for the new issue.

Flags: needinfo?(malexandru)
Regressions: 1699210

Please let sheriffs close bugs when changes merge to central, instead of closing yourself after autolanding.

Target Milestone: --- → 88 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: