1697779 - Perma js/src/jit-test/tests/wasm/gc/disabled.js | /builds/worker/checkouts/gecko/js/src/jit-test/lib/wasm.js:55:21 Error: Assertion failed: got false, expected true (code 3, args "") [0.1 s] when Gecko 88 merges to Beta on 2021-03-22

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulatiton
• How to run these simulations
• Failure log

[task 2021-03-11T10:53:46.614Z] TEST-PASS | js/src/jit-test/tests/wasm/gc/debugger.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.1 s]
[task 2021-03-11T10:53:46.631Z] /builds/worker/checkouts/gecko/js/src/jit-test/lib/wasm.js:55:21 Error: Assertion failed: got false, expected true
[task 2021-03-11T10:53:46.631Z] Stack:
[task 2021-03-11T10:53:46.631Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/gc/disabled.js:25:30
[task 2021-03-11T10:53:46.631Z] Exit code: 3
[task 2021-03-11T10:53:46.631Z] FAIL - wasm/gc/disabled.js
[task 2021-03-11T10:53:46.631Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/gc/disabled.js | /builds/worker/checkouts/gecko/js/src/jit-test/lib/wasm.js:55:21 Error: Assertion failed: got false, expected true (code 3, args "") [0.1 s]
[task 2021-03-11T10:53:46.631Z] INFO exit-status     : 3
[task 2021-03-11T10:53:46.631Z] INFO timed-out       : False
[task 2021-03-11T10:53:46.631Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/lib/wasm.js:55:21 Error: Assertion failed: got false, expected true
[task 2021-03-11T10:53:46.631Z] INFO stderr         2> Stack:
[task 2021-03-11T10:53:46.631Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/gc/disabled.js:25:30

etc.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1697779 - Fix feature gate testing and move test. r?lth

A previous commit made isValidTypeCode used in the fallthrough case of decoding types.
This doesn't work when features have been disabled at compile-time as disabled types
will not be caught by earlier cases and will fallthrough to isValidTypeCode which
does no checking of runtime flags of compile time flags and accept the type.

This commit tweaks the organization to prevent this from happening. Additionally, a
test that is valid with function-references enabled is moved from the gc/disabled.js
test to a new function-references/disabled.js test.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d76fb0e9c1d0
Fix feature gate testing and move test. r=lth

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d76fb0e9c1d0

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation.