1697781 - Perma test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature browser.startup.homepage.abouthome_cache.enabled should match runtime value. - true == false when Gecko 88 merges to Beta on 2021-03-22

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllHaveDefault - [testAllHaveDefault : 425] Feature webrtc-global-mute-toggles should have a non-null default value! - false != null
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  (xpcshell/head.js) | test run_next_test 7 pending (2)
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  (xpcshell/head.js) | test testAllHaveDefault finished (2)
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  toolkit/components/featuregates/test/unit/test_FeatureGate.js | Starting testAllDefaultsMatchSettings
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  (xpcshell/head.js) | test testAllDefaultsMatchSettings pending (2)
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  (xpcshell/head.js) | test run_next_test 7 finished (2)
[task 2021-03-11T11:39:59.252Z] 11:39:59  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature browser.startup.homepage.abouthome_cache.enabled should match runtime value. - true == false
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:testAllDefaultsMatchSettings:440
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:239
[task 2021-03-11T11:39:59.252Z] 11:39:59     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:567

Comment 1

[Bernard Igiri]

I've tested this on Linux and I'm not seeing these errors. How do I reproduce this?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Looking at the push from comment 0, the failure hits platforms except shippable (= optimized based on profiling. The preference from the failure message has a value based on its state as NIGHTLY_BUILD. It might be worth checking the differences for these.

Regarding building & testing: See the instructions how to run this on Try. I have never built beta builds locally except artifact ones. The Firefox CI can provide more info from the RelEng side.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The DevEdition failures are for dom.forms.inputmode where FeatureGate reports the unexpected value true.
Linux asan and debug are for browser.startup.homepage.abouthome_cache.enabled with unexpected true.

dom.forms.inputMode definition:
default-value = {default = true, android = true, release = false, beta = false}
The preference is true for Nightly and Android (source). The @IS_NOT_RELEASE_OR_BETA@ means "is not release or beta repository" (DevEdition and the update channel "aurora" are rebranded Betas these days).
This causes targetingFacts to beta as false because it evaluates the update channel.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1697781 - Adjust FeatureGate default for dom.forms.inputmode on DevEdition and check AppConstants.NIGHTLY_BUILD instead of update channel. r=bigiri

dom.forms.inputmode is false outside Nightly (Developer Edition is a
rebrand of beta with a different update channel configured and
RELEASE_OR_BETA checks are checks against this underlying configuration).

Linux x64 debug and asan builds use 'nightly' as update channel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caddf6de37fe
Adjust FeatureGate default for dom.forms.inputmode on DevEdition and check AppConstants.NIGHTLY_BUILD instead of update channel. r=preferences-reviewers,jaws

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/caddf6de37fe

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation.