Closed Bug 1697792 Opened 4 years ago Closed 4 years ago

Clean up info icons in the codebase

Categories

(Toolkit :: Themes, task)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

So many info icons :(

browser/themes/shared/controlcenter/info.svg
browser/themes/shared/info.svg
browser/themes/shared/notification-icons/default-info.svg
devtools/client/debugger/images/info.svg
devtools/client/themes/images/info.svg
toolkit/themes/shared/incontent-icons/info.svg

Let's reduce them into:

devtools/client/themes/images/info.svg
toolkit/themes/shared/icons/info-filled.svg
toolkit/themes/shared/icons/info.svg
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #9208372 - Attachment description: Bug 1697792 - Clean up info SVG icons in the codebase. r=Itiel,nchevobbe → Bug 1697792 - Clean up info SVG icons in the codebase. r=Itiel
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dcc686463127 Clean up info SVG icons in the codebase. r=Itiel

Backed out for failures on browser_parsable_css.js (missing chrome://devtools/skin/icons/info.svg referenced from chrome://devtools/content/netmonitor/src/assets/styles/messages.css)

backout: https://hg.mozilla.org/integration/autoland/rev/8d22f08c42d3424b757179ca6cef799a2c45d3ed

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=dcc6864631273a0f3b3c7519ebe10499f79ae02a&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=332943337&repo=autoland&lineNumber=3351

[task 2021-03-12T02:42:16.453Z] 02:42:16 INFO - Console message: [JavaScript Warning: "Error in parsing value for ‘animation-direction’. Declaration dropped." {file: "chrome://devtools/content/debugger/src/components/Editor/Editor.css?always-parse-css-0.19123285474240814" line: 172}]
[task 2021-03-12T02:42:16.453Z] 02:42:16 INFO - Buffered messages finished
[task 2021-03-12T02:42:16.454Z] 02:42:16 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://devtools/skin/icons/info.svg referenced from chrome://devtools/content/netmonitor/src/assets/styles/messages.css -
[task 2021-03-12T02:42:16.454Z] 02:42:16 INFO - Stack trace:
[task 2021-03-12T02:42:16.454Z] 02:42:16 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-12T02:42:16.454Z] 02:42:16 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:426

Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6aa095d1f534 Clean up info SVG icons in the codebase. r=Itiel
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Blocks: 1698137
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: