1697800 - webrtcUI.getActiveStreams should not throw during tab closing

Status: RESOLVED FIXED

(Firefox :: Site Permissions, task, P1)

Description

[Florian Quèze [:florian]]

If I fix bug 1596165, the browser_devices_get_user_media_multi_process.js test fails with this error:
TEST-UNEXPECTED-FAIL | browser/base/content/test/webrtc/browser_devices_get_user_media_multi_process.js | Uncaught exception - undefined - threw exception: TypeError: can't access property "ownerGlobal", browser is null

The problem is that the test does this:

      BrowserTestUtils.removeTab(tab);

      // Check that we still show the sharing indicators for the first tab's stream.
      await Promise.all([
        TestUtils.waitForCondition(() => !webrtcUI.showCameraIndicator),
        TestUtils.waitForCondition(
          () => webrtcUI.getActiveStreams(true, true, true).length == 1
        ),
      ]);

The first webrtcUI.getActiveStreams call happens at a time when the browser has already been destroyed, but the stream list hasn't been updated yet (the notification hasn't been processed yet).

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1697800 - webrtcUI.getActiveStreams should not throw during tab closing, r=johannh.

Depends on D108011

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aa593ee8002
webrtcUI.getActiveStreams should not throw during tab closing, r=johannh.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6aa593ee8002